bcgov
UI SAN Actions Court Order
- [x] Build Actions in Notice Panel (Court, Commission Orders, Edit/Delete Notice)
- [x] Create a wrapper for the Form
- [x] Court Order Form - question whether to re-use existing rules or re-use component - consider the fact that the order information could be changed (amended)
- [x] Character counter and drag handle to be visible (base component)
- [x] Keep all validations the same
- [x] When Form is submitted, content is readable as per design
@saragunnarsson This should be in DEV in about 15mins and ready for UXA, no rush, i will be off until Tuesday!
Thanks @cameron-eyds - it's looking really great! Just a couple items noted below. I think some of them are out of scope, so take a look and let me know if I should create a new ticket for those items.
-
[ ] Increase size of drag handle size to approx the pink line (it's a little hard to say, but somewhere around there)
. -
[x] Decrease space between orders to 3px
. -
[x] List Notices added with the newest one at the top. I missed this one when UXAing the SAN component. Would you like me to add it to a different ticket? Or create a new ticket? I'm not sure if it's an easy thing to throw in or if it messes with the estimate.. .
-
[x] When I add a court order to a notice in the middle of the list, the box jumps out and separates from the rest. It should stay in the same position and just expand down. .
-
[x] To add to that, and this is new, can we make it scroll to the top of the notice when adding/editing a notice? I noticed the form opens up quite far down on the page and it would be nice if the page scrolled to the section open.
@saragunnarsson Maybe we could review the UXA today, some of the items i will need some clarification on!
@saragunnarsson UXA updates should be in dev shortly. Oddly enough the only item i've been unable to manipulate is the size of the draggable handle on the text area... it's quite embedded. Will continue to research however.
That's alright @cameron-eyds - It's not that big of a deal. We can leave it as is. Just one thing listed below, otherwise it's good to go!
- [x] Set line-height to 22px
One more thing @cameron-eyds when you edit a court order the other orders should not be visible. See below:
@saragunnarsson Ah, so the Court Orders are not edited inline the same way as the Notices? I did them the same way as notices, so in the event there is multiple Court Orders, it will render the edit form in place of the Order review content. We want to hide all Court Orders and all Commission Orders whenever an edit is being made on a single Order? Either way, quick fix, updated and included as part of ticket #21111.
Line height updated, since it's so small, have included it in #21111 as well!
@cameron-eyds Yea that's right, slightly different behaviours for the two. It gets a bit much to have the orders open when editing so we changed the behaviour for orders. Thanks for handling that! 👌😊 I'll move this along to RFQA
@cameron-eyds @saragunnarsson Quick question - In the description of the ticket, I see the validations are same as existing court order form, but currently for the SAN court order, the validations for the Court Name, and Court Registry are not in place, and also for the 'effect of order' field, when the max characters are entered the validation is displayed as expected, but when removing the extra characters red error bar is still displayed. Please take a look, thanks!!
Existing Court Order component validation:
@chdivyareddy I followed the validations listed in the designs. Do we know what all the specific validations are that are not listed in the designs? Is it just the Max Character counts on these fields?
I've updated in my current work to include max character counts of 256 and 64 for name and registry respectively, we may want to include in design specs for future reference. Let me know if there was other validations required!
@cameron-eyds sorry, my mistake here...As this description of the ticket mentioned to keep all the validations same, my understanding was it should be similar to the existing component but the max count was not mentioned in the designs...So, not sure whether we need to include them or not... @LizGovier @saragunnarsson Can you please confirm, is there a max character count to the 'Court Name' and 'Court Registry' fields?
No no, all good! I think it was a good catch, i'm assuming the same now as well, that we will want the max character counts. Especially if these values are being stored in the legacy DB where restrictions such as this are more prevalent. If we were in POSTGRES only, might not be an issue, but better to have the safety than not, i think?
@chdivyareddy @cameron-eyds Yes, Divya good catch as always:) I wasn't aware that we had a max character count on those fields and I agree that it's a good idea to keep them for these orders as well. I'll make sure to add the spec to figma. Thanks both of you!
@chdivyareddy These updated validations should be in DEV very shortly, good catch and thank you!
Verified in DEV!
- When max character count is removed, then the validation is auto removed as expected:
