entity icon indicating copy to clipboard operation
entity copied to clipboard

UI - Review Page and Submission

Open LizGovier opened this issue 1 year ago • 8 comments

  • [x] Cancelled transport Permit Information Review
  • [x] Restored Label
  • [ ] When a home was exemption to due moving out of BC and is now moving back, show restored label
  • [x] Confirm Completion text
  • [x] Remove Staff payment component and validation
  • [x] Validations

Submission

  • [x] Omit location information current and previous (API KNOWS!)

LizGovier avatar Apr 25 '24 17:04 LizGovier

Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett

LizGovier avatar Apr 25 '24 18:04 LizGovier

Request from Fareen and the OCM Team: While doing the UXA, could screenshots be saved and sent to the OCM? This would be huge help during the creation of their user guides.

arlentees avatar Apr 29 '24 21:04 arlentees

@LizGovier is the Confirm Completion text still a pending item?

dimak1 avatar May 13 '24 15:05 dimak1

@PCC199 @LizGovier let's remove the pending item to a new ticket, so we can work on it once the Confirm Completion text is final?

dimak1 avatar May 13 '24 19:05 dimak1

Hey @dimak1 Just following up with Policy, but it doesn't seem ready yet. I would just add what's in the UI and I'll create a separate ticket like you suggested.

LizGovier avatar May 13 '24 21:05 LizGovier

Thanks @LizGovier, i've added the Confirm copy that is there in Figma.

I have another question, regarding Exempt MHRs and this bullet:

  • When a home was exemption to due moving out of BC and is now moving back, show restored label

Right now, if MHR is Exempt (for any reason), the Amend Transport Permit (and subsequently Cancel Permit) buttons are disabled. So, at the moment, we cannot fulfill the above requirement item, as we cannot activate the Cancel Permit flow.

I think we need a new ticket to update the code to not block Amend/Cancel flow if home is 'Exempt due to transport permit, correction, or public amendment' as in Figma (we discussed this briefly already).

dimak1 avatar May 14 '24 17:05 dimak1

Ready for UXA: https://bcregistry-assets-dev--pr-1875-wvuwl8y4.web.app

dimak1 avatar May 15 '24 15:05 dimak1

@dimak1 I have a ticket regarding the amend/cancel transport permit that is set for pre-grooming #21218 @arlentees This is a bug and should be a blocker for this ticket.

LizGovier avatar May 16 '24 16:05 LizGovier

@arlentees to get this ticket moving (along with UXA and QA) should we remove the unchecked item that's being blocked? Or I can take on the blocker ticket next.

dimak1 avatar May 17 '24 14:05 dimak1

Hey @dimak1 I can't get into the dev environment for staff so I don't have a way to check https://bcregistry-assets-dev--pr-1875-wvuwl8y4.web.app. Could you push this so I can test it as a QS on in the DEV environment?

LizGovier avatar May 17 '24 15:05 LizGovier

Hi @Liz, let me sync the recent changes and re-create a new preview link. I'll let you know.

dimak1 avatar May 17 '24 15:05 dimak1

@LizGovier ready: https://bcregistry-assets-dev--pr-1875-wvuwl8y4.web.app

dimak1 avatar May 17 '24 15:05 dimak1

Deployed to DEV (minus the item for exemption to due moving out of BC).

dimak1 avatar May 17 '24 17:05 dimak1

I added the last item (Restored badge on Review page). Ready for UXA in DEV.

dimak1 avatar May 22 '24 17:05 dimak1

Thanks @dimak1,

Just a few updates:

User: Staff

  • [x] Missing Location Change Type: 'Cancel Transport Permit' Screen Shot 2024-05-22 at 5.08.36 PM.png

  • [x] Add 80px of margin between the footer and Authorization Component Screen Shot 2024-05-22 at 5.19.17 PM.png

User: Qualified Supplier Lawyer/Notary

The following is preventing me to file a Transport Permit in order to rest the 'Cancel Transport Permit' review and confirm page MHR #108150 Issue: Unable to file Transport Permit Tried using the following address locations:

  • in BC
  • out of BC
  • Moving within the same Park Screen Shot 2024-05-23 at 8.13.22 AM.png

User: Qualified Supplier Manufacture

Was able to File, Amend and Cancel a transport Permit. Just one update:

  • [x] Missing Location Type Screen Shot 2024-05-23 at 8.33.06 AM.png

LizGovier avatar May 23 '24 12:05 LizGovier

@LizGovier thanks for feedback, I fixed the Location Change Type label. I also was able to submit the Transport Permit for MHR 108150 using QS (BCREG0062). Link: https://bcregistry-assets-dev--pr-1893-4e7zwo3g.web.app

I tried the same QS account as in your screenshot and was not able to submit Transport Permit for MHR 108329 using QS (BCREG0018). The reason is: rootCause: "detail:[Additional validation: The existing location must be a dealer or manufacturer lot for this registration. ],message:003: Registration request data validation errors. " This error coming up pretty frequently, but we only show the generic error modal, so it's causing many false positives scenarios.

dimak1 avatar May 23 '24 14:05 dimak1

@dimak1 QS Lawyer/Notary (BCREG0018) should be able to file a transport permit on any manufactured home, they shouldn't be restricted, so this rule shouldn't apply.

Screen Shot 2024-05-23 at 4.17.17 PM.png

Note, I'm unable to use the UXA links for QS (https://bcregistry-assets-dev--pr-1893-4e7zwo3g.web.app). It would have to be deployed to DEV for me to test

LizGovier avatar May 23 '24 20:05 LizGovier

Hi @doug-lovett could you update API validation for the error above, as per comment from Liz?

dimak1 avatar May 23 '24 21:05 dimak1

@LizGovier @dimak1 looking at the roles assigned to BCREG0018 it is not a qualified supplier notary/lawyer. Test with BCREG0062 instead.

doug-lovett avatar May 23 '24 22:05 doug-lovett

@LizGovier please try the BCREG0062 instead.

dimak1 avatar May 23 '24 22:05 dimak1

Hey @dimak1 That worked, thank you! Review and confirm screen looks great and is RFQA.

There is just one item I was hoping you could update on the initial Cancel Transport Permit screen. The line-height in the restored location section is a bit too large. It should be similar to what we have on the Review and confirm page. I can create a separate ticket if needed.

Initial Cancel Permit Page Screen Shot 2024-05-24 at 9.44.21 AM.png

Review and Confirm Page - Preferred Line Height Screen Shot 2024-05-24 at 9.44.32 AM.png

LizGovier avatar May 24 '24 13:05 LizGovier

Good eye Liz! Fixed the styling and deployed to DEV.

dimak1 avatar May 24 '24 15:05 dimak1

Verified in DEV!

Staff: image.png

image.png

QS: image.png

chdivyareddy avatar May 28 '24 18:05 chdivyareddy