entity icon indicating copy to clipboard operation
entity copied to clipboard
verified publisher icon bcgov

Create UI: implement manual business entry (DO THIS BEFORE 21008)

Open severinbeauvais opened this issue 1 year ago • 3 comments

  • [x] implement the bottom part of this component: image.png

  • [x] add the jurisdiction selector (reuse from elsewhere): image.png

  • [x] if jurisdiction is not MRAS, prompt for business information: image.png

  • [x] no confirmation checkbox in this case

  • [x] handle Undo (go from results mode to initial mode and clear out any data)

  • [x] store data in store object

  • [x] save and resume data in filing

  • [x] verify component reloads data from draft

  • [ ] add unit tests for new code

severinbeauvais avatar Apr 24 '24 16:04 severinbeauvais

Hi Ketaki. Be aware that Yui and I are still working through some of the designs.

In addition to the main Figma file, also look at this: https://www.figma.com/file/wVF8EcUCUR20YyqA0wHVJp/Continuation-In-V5?type=design&node-id=525-1868&mode=design&t=o6gNbY8mbNUMMVpn-0

Ask me or Yui if you have questions.

severinbeauvais avatar May 03 '24 17:05 severinbeauvais

Sounds good. Thanks Sev!

ketaki-deodhar avatar May 03 '24 17:05 ketaki-deodhar

There are 2 bugs to be fixed which are listed in a new ticket 21315

ketaki-deodhar avatar May 16 '24 23:05 ketaki-deodhar

@yuisotozaki @OlgaPotiagalova, BN field might require validation,

I have entered the NA image.png COLIN - if BN can blank or number not alpha . See below snapshot image.png

NaveenHebbale avatar May 21 '24 15:05 NaveenHebbale

I added a todo item to #21315 for the BN validation. Please expand there if there is any special validation you want, otherwise we will copy what is done in other places that BN is entered.

severinbeauvais avatar May 21 '24 16:05 severinbeauvais

@severinbeauvais, BN verification it is should be 9 digital numbers only which might be similar to the existing validation

NaveenHebbale avatar May 21 '24 16:05 NaveenHebbale

Observations:

  • There should be character max limit for Identifying Number (Maybe set to 50)
  • There should be character max limit for Business Name in Home Jurisdiction (Same as our business name max)
  • If MRAS jurisdiction is chosen, the manual fields do not show up. I guess this is OK because non-expro, MRAS path is not part of this ticket.

yuisotozaki avatar May 21 '24 23:05 yuisotozaki

@yuisotozaki , I copied your observations to the next ticket (21315). Can this ticket be moved to RFQA now?

severinbeauvais avatar May 22 '24 18:05 severinbeauvais

Ready for QA

yuisotozaki avatar May 23 '24 14:05 yuisotozaki

Closed ,

NaveenHebbale avatar May 28 '24 20:05 NaveenHebbale