bcgov
Transport Permit - Tax certificate expiry date
- [ ] For the transport permit location type Dealer's / Manufacturer's lot, when the user enters the tax certificate expiry date as June 19, 2024, than in the review screen displays as June 18, 2024.
MHR info screen:
Review & Confirm:
@chdivyareddy the date bug is related to timezones. The Tax Certificate Exp Date that is selected and the date that is shown in Review page (in Pacific Timezone) could be different. This is because we capture the date as plain text eg 2024-05-28, but display using timeZone: 'America/Vancouver'.
I can remove the timezone and display the date as entered. I wanted to verify what would be displayed in Outputs (to make sure we all show the same date), but there are no Tax Cert Exp Date in the outputs.
Just want to make that we want to remove Pacific timezone conversion here? Because we use this function in many places already.
cc: @arlentees
@dimak1 I'd be cautious around changing the display if the component is used in many places. Do we only capture the date as year-month-day with no time
@arlentees yea i'm trying to be cautious, especially around dates, hence calling it out. For this date, we only asking for a date (no time). Context: We have a function that outputs the date (and sometimes time if captured) in the Pacific date/time. We use this function in a lot of places (Tombstone, Unit Notes, Exemptions, etc). Maybe the issue only when using it without the time, I can look into few of the instances. Or maybe we should explicitly let users know that this is Pacific date/time.
I checked the Pacific time conversion for other dates in the app.
For example, Transport Permit Date of Expiry for MHR 108329 is June 15, 2024 (2024-06-15T06:59:59+00:00). Pacific time is 7 or 8 hours behind the UTC time (depending on daylight saving time), so when subtracted from provided time it becomes 2024-06-14T23:59:59-07:00, which is June 14, 2024.
Discussed at the stand-up today to keep Pacific time conversion function as is, and do not use it for the original issue of the ticket (Tax Certificate date), just show the date as it was selected by the user.
