entity icon indicating copy to clipboard operation
entity copied to clipboard

UI - Transfers - Adding a Person jumps to next section

Open LizGovier opened this issue 1 year ago • 14 comments

DEV and TEST environment for both QS and Staff

All Transfer Types When adding/Editing a person or business and click 'Done', the screen jumps to the next section below when it should remain on the ownership component.

Solution: Add a 'Scroll to' effect when clicking 'Done'. Should scroll to the top of the Owners Table.

Clip Private Zenhub Video

LizGovier avatar Apr 05 '24 15:04 LizGovier

@LizGovier @arlentees I updated to scroll to the top of Home Owners table, but I don't think it is bug, more of enhancement.

dimak1 avatar Apr 09 '24 20:04 dimak1

Preview link: https://bcregistry-assets-dev--pr-1818-nb8t7z4v.web.app/

dimak1 avatar Apr 09 '24 20:04 dimak1

Hey @dimak1 We groomed this last week and decided it should be in the bug column as this might have been a Vue 3 upgrade issue.

I'm still getting the same result when I add a person.

Private Zenhub Video

LizGovier avatar Apr 09 '24 21:04 LizGovier

@LizGovier bug it is.. but you are not using the preview link :)

dimak1 avatar Apr 09 '24 21:04 dimak1

Hey @dimak1 I'm on the Dev Environment using the link https://bcregistry-assets-dev--pr-1818-nb8t7z4v.web.app/dashboard and still getting the same result where I get jumped down to the next section:

LizGovier avatar Apr 10 '24 00:04 LizGovier

@LizGovier I fixed the scroll. Add, Remove, Cancel buttons, for Person and Business should scroll to top of table now. Preview link: https://bcregistry-assets-dev--pr-1818-nb8t7z4v.web.app

dimak1 avatar Apr 10 '24 15:04 dimak1

Thanks @dimak1 ! I can see it now. Is it possible to have it stoll to the top of the 'Add a person' button. It would be good for the users to see the Home Tenancy Type.

Screen Shot 2024-04-10 at 12.25.29 PM.png

LizGovier avatar Apr 10 '24 16:04 LizGovier

@LizGovier yes, it's easy to update, will do!

Edit: it's done https://bcregistry-assets-dev--pr-1818-nb8t7z4v.web.app/

dimak1 avatar Apr 10 '24 16:04 dimak1

Thank you @dimak1 This is great and RFQA!

LizGovier avatar Apr 11 '24 02:04 LizGovier

Merged to Dev.

dimak1 avatar Apr 11 '24 18:04 dimak1

Hey @dimak1 , looks like Chrome and Safari is working as expected, but with the Firefox browser, it doesn't auto scroll to the owners table, please take a look, thanks!

Current Behavior (Firefox): image.png

chdivyareddy avatar Apr 12 '24 18:04 chdivyareddy

@chdivyareddy thanks Divya, yes I can reproduce this in Firefox and looking into the fix.

dimak1 avatar Apr 12 '24 19:04 dimak1

Fixed scroll for Firefox and merged to DEV.

dimak1 avatar Apr 12 '24 20:04 dimak1

Verified in DEV!

image.png

chdivyareddy avatar Apr 12 '24 21:04 chdivyareddy