entity icon indicating copy to clipboard operation
entity copied to clipboard

UI - MHR Table | Cancelled Homes

Open arlentees opened this issue 1 year ago • 3 comments

Staff MHR Table Regarding Cancelled Homes

  • Staff can add cancelled homes to their table
  • Can open the MHR Home
  • Buttons to be added: Re-Register Manufactured Home and Remove from Table

MHR Information Page Updates:

  • Remove part of description test
  • Hide Buttons: Corrections, Public Amendment, Change Ownership, Change Location
  • Unit Notes Table (Show Public and Confidential note in dropdown)

Qualifies Suppliers QS can not add a cancelled home to their MHR table. If QS try to add a cancelled home to their table, a new model will replace the current confirmation modal. See figma designs for more details.

Figma Design File

arlentees avatar Apr 02 '24 21:04 arlentees

Questions for staff

  • Can you open a cancelled home (Yes)
  • can you re-register a cancelled home (Yes)

LizGovier avatar Apr 02 '24 21:04 LizGovier

Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @doug-lovett

PCC199 avatar Apr 04 '24 16:04 PCC199

This has been reviewed with Scott and is ready for Dev.

LizGovier avatar Apr 08 '24 15:04 LizGovier

Please add your planning poker estimate with Zenhub @dimak1

PCC199 avatar May 23 '24 16:05 PCC199

Here are some MHR numbers for cancelled homes: 088867 088868 088960 089331 089379 089384 089398 089430 089454 089489 089493 089524 089558 089559 089618 089786 090001 090183 090319 090419 090453 090500 090509 090745 090789 091219 092127 092152 092361 092542 092656

doug-lovett avatar May 29 '24 23:05 doug-lovett

@LizGovier right now, for Exempt MHRs, one of the conditions to enable 'Re-Register Home' dropdown button is when home location type is not MANUFACTURER or MH_PARK. Would the same condition apply for Cancelled MHRs?

Here are existing conditions to enable 'Re-Register Home' button:

  1. Staff Role
  2. FF enabled: mhr-exemption-enabled
  3. MHR has child residential or non-res exemption
  4. Home location type is not MANUFACTURER or MH_PARK

Please let me know if Cancelled MHRs would have any overlapping conditions. Thanks!

dimak1 avatar May 31 '24 12:05 dimak1

@LizGovier @saragunnarsson please approve my request to access figma designs for this ticket (Cancelled MHRs). Thanks!

dimak1 avatar May 31 '24 14:05 dimak1

Hey @dimak1 Only staff can re-register a cancelled manufactured home as QS can not add cancelled homes to their MHR Table. So 'Home location type is not MANUFACTURER or MH_PARK' does not apply.

LizGovier avatar May 31 '24 14:05 LizGovier

@dimak1 As per our conversation, because this is a staff only filing and the conditions above were added before transport permits and corrections, the conditions to enable 'Re-Register Home' button are:

  • Staff Role
  • FF enabled: mhr-exemption-enabled
  • FF enabled: cancelled home (not sure what the code is for that)

For re-registration we do not need:

  • MHR has child residential or non-res exemption
  • Home location type is not MANUFACTURER or MH_PARK

LizGovier avatar May 31 '24 16:05 LizGovier

Thanks @LizGovier I will update the conditions, however we don't have feature-flag for Cancelled Home, so I will omit this, but add the check for Exempt status and Cancelled status.

dimak1 avatar May 31 '24 18:05 dimak1

Ready for UXA: https://bcregistry-assets-dev--pr-1907-skxdqt7v.web.app/

dimak1 avatar May 31 '24 21:05 dimak1

Merged to DEV.

dimak1 avatar Jun 03 '24 11:06 dimak1

Hey @dimak1 Reviewed both Staff and QS views for Cancelled homes. All looks good and is RFQA.

LizGovier avatar Jun 03 '24 20:06 LizGovier

Thanks Liz. Ready in DEV.

dimak1 avatar Jun 03 '24 20:06 dimak1

@LizGovier @dimak1 , Just want to confirm the Cancelled home registration dropdown in the MHR table for staff account. Currently, it displays 'Non-Residential Exemption' as well, but in the designs I don't see it in DEV. Please take a look, thanks!

image.png

Design: image.png

chdivyareddy avatar Jun 04 '24 20:06 chdivyareddy

As per ticket #21421 I removed the conditional check for home location, so the only condition that's left is to check for Staff Role + Exemptions Feature Flag.

dimak1 avatar Jun 04 '24 20:06 dimak1

@dimak1 @chdivyareddy, yes you are correct! Non-Residential Exemption should not be part of the dropdown for a cancelled home.

LizGovier avatar Jun 05 '24 16:06 LizGovier

Ok I will update it, thanks!

dimak1 avatar Jun 05 '24 17:06 dimak1

Fixed and merged to DEV.

dimak1 avatar Jun 07 '24 20:06 dimak1

Verified in DEV!

Staff: image.png

image.png image.png

Qualified Supplier: image.png

chdivyareddy avatar Jun 10 '24 20:06 chdivyareddy