bcgov
Staff Dashboard - Implement Safe List Addition and Removal
Safe Email List (DEV/TEST) is in staff dashboard in DEV and TEST. However It is empty and needs implementation.
I think the reason the list is empty is because cors policy needs to be updated to include *.run.app urls from gcp, probably here https://github.com/bcgov/sbc-auth/blob/3c78b5029091c96c16fbd16d383508f899945906/auth-web/firebase.json#L23 that's where safe_list api is called from. So, I think that would populate the list. What needs to be implemented is another api to add users to the list.
@pwei1018 is your team able to pick up this work, or do we need to groom it
Requirements:
- [ ] Add 'DELETE' Option to notify-api safe_list endpoint;
- [ ] Add 'Add' function in Staff Dashboard' Safe Email List section;
- [ ] Add 'Remove' function of each email in the list;
@shaangill025 So I have no idea where this functionality is? Can you point me to it so I can take a look?
@rstens
url: https://dev.account.bcregistry.gov.bc.ca/staff/dashboard/active
Adding and deleting do not refresh the page automatically, you have to reload to see the result. That is confusing as there is no indication that something happened. Maybe that should be changed. @shaangill025 @pwei1018
Yes, https://github.com/bcgov/sbc-auth/pull/2843 includes the required changes.
[4:44 p.m.] Stens, Roland K CITZ:EX https://github.com/bcgov/entity/issues/20463 Is done but I found a defect/issue Shanjot has provided a new PR for this, see comments in ticket. My question is do you want this included in the next release or do you want to wait until the new PR is done? Staff Dashboard - Implement Safe List Addition and Removal · Issue #20463 · bcgov/entity Safe Email List (DEV/TEST) is in staff dashboard in DEV and TEST. However It is empty and needs implementation. [4:47 p.m.] Wei, Patrick CITZ:EX This change is only available in Dev and Test. So, no release need. Your team can check with Relationship team to see when the PR can merge and deploy.
@ozamani9gh Your opinion?
@rstens Fix is live in https://dev.account.bcregistry.gov.bc.ca/staff/dashboard/active
@shaangill025 and @rstens please confirm this is now working in DEV and TEST. If so we can close ticket.
@ozamani9gh @ozamani9 It is working in DEV but not in TEST (yet). I also communicated with @shaangill025 the following: Looks OK but..... If you add an email address, it would be nice that as part of the refresh you actually remove the email from the data entry field, so the user has some visual confirmation that it was done. Maybe even a message somewhere that it was added.
Tested the few iterations in DEV and it looks good. However, the latest version is not yet deployed in TEST. Shaanjot is following up with Travis.
@ozamani9gh @shaangill025