entity icon indicating copy to clipboard operation
entity copied to clipboard

Account Details missing

Open pstemkens opened this issue 1 year ago • 11 comments

On older accounts, some account details are missing

ie. ~Branch/Division (this field is optional)~ Business Type: Mailing Address:

GIVEN details fields are blank WHEN client accesses the account THEN they are prompted to update the details missing.

Design: https://www.figma.com/design/NcchZlxVp502zeoiCLeMgi/Enhancements-for-Staff?node-id=2881-6529&t=YZtgVOoNNotXo4eX-4

Make sure that auth doesn't crash when info is missing (Client can still use their products/filings) Make sure that missing info is a required field IF they edit account details.

pstemkens avatar Feb 27 '24 00:02 pstemkens

@ethantspitt , can we discuss this one as well?

pstemkens avatar Jun 13 '24 14:06 pstemkens

some sort of warning - missing information

ethantspitt avatar Jun 13 '24 17:06 ethantspitt

@ethantspitt ,we need a warning to show when information is missing on older accts

pstemkens avatar Jun 18 '24 20:06 pstemkens

@pstemkens @ethantspitt Can you please review the current state of what happens when an account is missing info? We have two goals in my opinion:

  1. Make sure that auth doesn't crash when info is missing
  2. Make sure that missing info is a required field IF they edit account details.

JohnamLane avatar Jun 19 '24 16:06 JohnamLane

Ethan will work to get a design done.

pstemkens avatar Jun 19 '24 17:06 pstemkens

@ethantspitt , have you had a chance to do a design for this one? thanks.

pstemkens avatar Jul 02 '24 17:07 pstemkens

@pstemkens in progress, I worked with @Jxio on how the account page looks like when different account info is missing: https://docs.google.com/spreadsheets/d/1a5JHNFbfsAjlLXza_Flx5adbadr5IuLB7EcK6qdxNp8/edit?usp=sharing

design in progress for the expected screen / mock-up for each scenarios.

ethantspitt avatar Jul 03 '24 15:07 ethantspitt

@pstemkens I've got some findings from using the test accounts in dev. Figma link

It'd be great to chat about them when you've got a moment. Thanks

ethantspitt avatar Jul 04 '24 15:07 ethantspitt

Hey team! Please add your planning poker estimate with Zenhub @Jxio @rodrigo-barraza @ochiu @avni-work @sameer0422 @lizhuomeng71

pstemkens avatar Jul 04 '24 18:07 pstemkens

Please add your planning poker estimate with Zenhub @seeker25

pstemkens avatar Jul 04 '24 18:07 pstemkens

Please add your planning poker estimate with Zenhub @avni-work

pstemkens avatar Jul 04 '24 18:07 pstemkens

Waiting item to be push to test

lizhuomeng71 avatar Jul 25 '24 22:07 lizhuomeng71

It should be on test"version": "2.6.52",

We're on version:

image

seeker25 avatar Jul 25 '24 23:07 seeker25

for QA: Account Info page converted to composition-api, the related page&functionality need to re-test - change business/address, suspend account, nsf account page...

Jxio avatar Aug 07 '24 16:08 Jxio

@sameer0422 ops team got an issue: a GOVN org is seeing warning message when it missing type. type/size check suppose only for business org.

Jxio avatar Aug 08 '24 23:08 Jxio

Message is confirmed

image.png

lizhuomeng71 avatar Aug 13 '24 21:08 lizhuomeng71

Steps to Reproduce:

Open the Account Info page for an individual account. Change the account type from Individual to Business. Ensure Business Type and Business Size fields are left empty. Click Save. Expected Result: Error messages stating "A business type is required" and "A business size is required" should be displayed.

Actual Result: No error message is shown, and the changes are not saved.

image.png

Moving this to new ticket

lizhuomeng71 avatar Aug 13 '24 22:08 lizhuomeng71

verified GovN no longer show warning message when type and size is empty

lizhuomeng71 avatar Aug 13 '24 22:08 lizhuomeng71