entity icon indicating copy to clipboard operation
entity copied to clipboard

MHR - Unit Notes (Exempt Home)

Open LizGovier opened this issue 2 years ago • 10 comments

Example : MHR 107956

  • [x] When a manufactured home is exempt, staff should be able to file the following Unit Notes :

  • Public Note (NPUB)

  • Confidential Note (NCON)

  • [x] UXA Comment: Dropdown container should hug the width of the largest Unit Note type (See design in Expected Result)

Showing in DEV : Screen Shot 2024-01-08 at 8.06.38 PM.png

Expected Result: Screen Shot 2024-01-08 at 8.11.13 PM.png

LizGovier avatar Jan 09 '24 01:01 LizGovier

@LizGovier Initially, we had both dropdown options (PUB & CONF notes) for staff. Then, a couple of months ago, it was removed. Should I add it back?

Screenshot 2024-04-10 at 10.54.29.png

dimak1 avatar Apr 10 '24 17:04 dimak1

@dimak1 I'm not sure what Figma Design he was referring to, but there should be a confidential note and public note on exempt homes. Thanks for catching that Dima.

LizGovier avatar Apr 10 '24 18:04 LizGovier

Ready for review: https://bcregistry-assets-dev--pr-1821-plhv6m49.web.app/

dimak1 avatar Apr 10 '24 19:04 dimak1

Hey @dimak1

Now I'm seeing all the Unit Note types on exempt homes. I'm also seeing unit notes for Transport Permits and Amending a Permit which shouldn't be there.

Screen Shot 2024-04-10 at 3.55.48 PM.png

LizGovier avatar Apr 10 '24 19:04 LizGovier

@LizGovier I just reverted one line of code, Roy's change. This must be a different bug. I can take a look if we can describe the issue:

  • For Exempt MHR, there should be no Unit Notes in the table?

dimak1 avatar Apr 10 '24 20:04 dimak1

@dimak1 There could be unit notes, but there shouldn't be unit notes for anything to do with Transport permits and amending a permit

LizGovier avatar Apr 10 '24 20:04 LizGovier

@LizGovier could you please point me to a rule/requirement where it clearly defines which Unit Notes are displayed/hidden?

Edit: let's create a separate ticket for the Unit Notes issue, and move this small ticket along. Let me know if it's good to go to DEV for QA. Thanks!

dimak1 avatar Apr 11 '24 19:04 dimak1

@dimak1 Sounds good! I created a bug ticket #20812

LizGovier avatar Apr 11 '24 20:04 LizGovier

@LizGovier Quick question - is this update only for the registrations Exempt due to Residential Exemption or to the registrations with the status change or location change as well?

Current behavior: This is only displayed for the residential exemption registrations

MHR 100451 image.png

  • Registrations which have been exempt due to location change/status change: 108302 image.png
image.png

chdivyareddy avatar Apr 12 '24 18:04 chdivyareddy

Hey @chdivyareddy

If a home is exempt, then the Unit Notes table should only display 'Public Note' and 'Confidential Note' in the dropdown. That would be for any type of filing that could exempt a home (EXRS, EXNR, 102, AMEND_PERMIT, PUBA, REGC)

LizGovier avatar Apr 15 '24 17:04 LizGovier

@LizGovier Thanks for confirming! @dimak1 moving this back to In Progress, Please take a look at the comment by Liz, thanks!!

chdivyareddy avatar Apr 15 '24 18:04 chdivyareddy

Working on it.

dimak1 avatar Apr 15 '24 18:04 dimak1

@LizGovier the dropdown with only Public Note and Confidential Note would show if MHR has active/existing exemption (Res or Non-Res). It was implemented as part of #17422 ticket. I would need some direction before making changes. Do we want to preserve existing requirement and check if MHR is exempt for any reason, display the two notes (as per your comment)?

dimak1 avatar Apr 15 '24 19:04 dimak1

@LizGovier I fixed to check if MHR is Exempt and show reduced Unit Note dropdown. Preview link: https://bcregistry-assets-dev--pr-1828-56n2ntft.web.app/

dimak1 avatar Apr 15 '24 20:04 dimak1

Hey @dimak1 Thank you for making this updated. I was going through tickets for PUBA and REGC and couldn't find one regarding Unit Notes which means it was overlooked. But to answer your question, no matter how the home was exempt, the Unit Note Table should only display 'Public Note' and 'Confidential Note'

LizGovier avatar Apr 15 '24 21:04 LizGovier

Hey @dimak1 Review for location change and exemptions. All looks good and RRFQA

LizGovier avatar Apr 15 '24 23:04 LizGovier

Verified in TEST for both residential exemption and location change using transport permits.

image.png image.png

chdivyareddy avatar Apr 17 '24 17:04 chdivyareddy