entity icon indicating copy to clipboard operation
entity copied to clipboard

UI - BUG | Unit Notes / Cancel (Person Giving Notice)

Open LizGovier opened this issue 2 years ago • 3 comments

When I cancel a NPUB (Public Note), NCON Confidential Note:

  • Person Giving Notice should be optional and have the checkmark beside it
  • the person giving notice information should carry forward from the original filing. Ex: If the checkbox was selected when a Public Note was file, it show as selected when cancelling.

See Designs: https://www.figma.com/file/FVvx7KgHDCAfejklfoue3L/MHR---Unit-Notes?type=design&node-id=1792-43093&mode=design

Error (DEV) Private Zenhub Image

LizGovier avatar Oct 28 '23 13:10 LizGovier

Hey @arlentees , from the description mentioned above for the cancel unit note, the checkmark should be auto-selected for the person giving notice when the initial unit note person giving notice checkmark was checked and also noted that the Attention field value is being retained from the initial unit note filing to the cancel unit note. So, moving this back to product backlog for now, thanks! cc @LizGovier

MHR 108170 in TEST:

  • [x] Public Note:
image.png

Cancel Public Note: If the checkbox was selected when a Public Note was filed, then it should show as selected when cancelling.

image.png
  • Attention value is retained from the initial public note filing:
image.png
  • [x] Confidential Note:
image.png
  • Cancel Confidential Note: If the checkbox was selected when the Confidential Note was filed, then it should show as selected when cancelling.
image.png
  • Attention value is retained from the initial confidential note filing:
image.png

chdivyareddy avatar Jul 08 '24 20:07 chdivyareddy

Thanks @chdivyareddy ! I took a look at he figma file and there might be a difference between what's in the design and what's described here in this ticket. @LizGovier can you weigh in?

arlentees avatar Jul 08 '24 22:07 arlentees

@arlentees It looks like the values for NPUB, NCON, and 103 are not being carried over when being cancelled, meaning if 'There was no person giving notice' was selected on the initial registration, it should be carried over when cancelling the note. Also, the Attention value is not supposed to retain the initial confidential note filing. So these two things will need to be fixed.

LizGovier avatar Jul 09 '24 12:07 LizGovier

Hey @flutistar Brandon, everything looks great...just a minor fix for the Attention value field for notice of redemption (other cancel notes attention fields works as expected). When a Notice of tax sale is cancelled (Notice is redemption), the Attention value is retained from the Notice of Tax Sale filing. Can you please take a look, thanks!

MHR 108170 in TEST. Steps to reproduce:

  • File a Notice of tax sale unit note (enter the attention value)
  • Now, file Notice of Redemption
  • Navigate to the review screen, attention field value is pre-populated
image.png image.png

chdivyareddy avatar Jul 17 '24 22:07 chdivyareddy

Yep I will fix it.

flutistar avatar Jul 18 '24 18:07 flutistar

Looks good! MHR 108356 - In DEV When filing a Notice of Tax Sale and adding 'Attention to:', the attention field is blank upon filing a noticed of redemption.

RFQA

LizGovier avatar Jul 22 '24 19:07 LizGovier

Verified in DEV!

MHR 108334:

image.png

chdivyareddy avatar Jul 22 '24 22:07 chdivyareddy