bcgov
UI - SAN Amendment Framework
- [ ] Launch into registration details from table
- [ ] Parse registration snapshot for comparisons
- [ ] Implement the SAN component into the amendment flow
- [ ] Include SAN model into changes required validation
Hey team! Please add your planning poker estimate with Zenhub @cameron-eyds @chdivyareddy @dimak1 @doug-lovett
Since we've only the one ticket for Amendments for the SAN, i've added a few task items required to complete this filing e2e and subsequently increased the estimate.
Hey @cameron-eyds - A few things listed below:)
- [x] This thing is still happening (reg: 100218Q)
- [x] Undo on the notice should only appear if the notice has been amended. If an order is edited/deleted, they should have individual undo buttons:
-
[x] When a new order is added to a new notice, the order doesn’t need a badge. If this is a weird one then we can chat about it after stand up tomorrow. It's a 'nice to have' user experience wise but not a necessity if it complicates things.
-
[x] Move badges on Notice WITH Orders 7px to the left
-
[x] Move badges on Notice WITHOUT Orders 4px to the right
-
[x] Move badges on Orders 4px to the right
-
[x] When i click remove/delete order in a notice with several orders, the notice collapses after deleting. Keep it open/expanded until the user closes it.
-
[x] There are no fees for amending the notices
-
[x] Update minlength validations on Effect of Order to 5 chars
@saragunnarsson Sounds good, thank you. Mostly small things!
The one item i'd like to discuss though is the Amended Badge on the Parent Notice when we modify a child Order. Since the orders are part of the Notice, changing an order results in an amended Notice. For example, if we change an order on a notice, we include the whole notice as part of the amendment, not just a singular order etc.
@cameron-eyds I agree, that's my understanding as well..Maybe I didn't explain something in there right. I went back and numbered the items, which one is that in regards to? We can def discuss tomorrow!:)
@saragunnarsson Totally! No rush at all on my end, lets discuss after standup. I'll get the small things in the meantime :)
@saragunnarsson With regards to item #1: I looked into 100218Q and this is an odd scenario! This Registration has an unknown Notice Type coming back from the API. Not a UI bug, just a type we don't support. Did you create this Security Notice or was this done via api/postman? Just wondering how this Notice type got populated haha
Here is a screen highlighting the type value. It is defined as Notice of Preservation
Interesting scenario either way, we can ask Doug if we need to build out support for this?
@saragunnarsson @cameron-eyds please ignore the 100218Q registration. It was created by me via the API and has a timestamp of 2024-04-29 18:55:10. Originally there were 3 notice types from the UX design. In general you can ignore any registration with a folio starting with "T-" as it is a unit test registration created by me.
@doug-lovett Perfect, thank you for confirming sir! Will gladly ignore :D
Awesome, thanks @cameron-eyds - It's looking really great, just a couple minor things below:
-
[x] Missing badge on notice
-
[x] On new/added notices/orders we say “Remove Notice/Order” On existing notices/orders we say “Delete Notice/Order”.
So the Amend dropdown should have a ‘Delete Notice/Order”’
Edit drop downs should have “Remove Notice/Order”
- [x] The warning modal should only appear on new/added notices with orders attached. When deleteing an existing order, we get the undo button so the waring modal is not necessary. This should have probably been called out, sorry about that.
@saragunnarsson With regards to item one, the last uxa round requested that we not add the AMENDED action to the parent notice when the child orders are amended, so i'm a little confused on this one haha
@cameron-eyds hmmm are you referring to this one (see screenshot below)?
I was referring to that the link should not be Undo unless the Notice itself had been amended (in that case the child had been amended and the undo was on the parent). Is the badge set to go with a certain action? Maybe we need to jump on a call to discuss after all haha
Oh! One more thing @cameron-eyds there's new copy for the details description component. It should say: "If this registration is related to a partial transfer of collateral to a new debtor, then enter the prescribed information below, otherwise the Details Description is optional."
Verified in TEST!
- When a new order is added to the existing Notice of Order:
Review & Confirm:
-
When a notice is added + removed:
-
When a notice is added:
-
When a notice is removed:
