entity icon indicating copy to clipboard operation
entity copied to clipboard

Auth API: updates for new entity types

Open severinbeauvais opened this issue 3 years ago • 1 comments

  • [ ] add new corp types to corp_types
    • BC = BC Limited Company
    • CC = BC Community Contribution Company
    • ULC = BC Unlimited Liability Company
  • [ ] save corp type for IA (and registration and NR?) affiliations
  • [ ] return corp type (legalType) in business.corpType object
  • [ ] consider NOT overloading the corpType (aka code) property and saving "whether this is an NR or IA or a reg" (ie, currently NR/TMP/RTMP) in a different field
    • this may require a db conversion
    • I am not sure of other BE impacts of this
    • I am not sure of other FE impacts of this
  • [ ] anything else related to this?
  • [ ] update unit tests

severinbeauvais avatar Nov 04 '22 21:11 severinbeauvais

@JohnamLane @pwei1018 @seeker25 @jdyck-fw @Mihai-QuickSilverDev - for grooming and planning

severinbeauvais avatar Nov 04 '22 21:11 severinbeauvais

@JohnamLane @seeker25 @ritvick @thorwolpert

What do you guys think about this ticket, ie, saving the legal type of an IA (and registration probably) in the Auth db? This is so that ticket 14113 can show the legal type of a numbered IA on the My Business Registration table.

This is code running locally (not merged) but you can imagine the legal type (BC Benefit Company, BC Unlimited Liability Company, BC Sole Proprietorship, etc) displaying in the Type column under the filing type:

image.png

NB: The business name column currently shows "Numbered Company" because we don't know what kind of numbered company this is. Previously it could only be a "Numbered Benefit Company" but now we're addding BC, CC and ULC legal types. You see the problem.

severinbeauvais avatar Nov 08 '22 18:11 severinbeauvais

Linda decided in grooming today that we should implement this properly now (as opposed to MVP version then implement it).

Leaving this with Lekshmi + Travis as they know what's needed here.

severinbeauvais avatar Nov 10 '22 18:11 severinbeauvais

Moving this to Grooming in the relationships team space to match this last comment @PCC199 @JohnamLane

jdyck-fw avatar Nov 10 '22 18:11 jdyck-fw

@lekshmimallika-aot When this is implemented, the UI will already display the legal type as expected, so you can test that way :)

severinbeauvais avatar Nov 10 '22 18:11 severinbeauvais