entity icon indicating copy to clipboard operation
entity copied to clipboard

PAY-API - CSO/BCONLINE - quantity * service fee not being handled correctly

Open seeker25 opened this issue 3 years ago • 1 comments

I don't think it's possible in our current implementation to bill for

Quantity * Service Fees + Quantity * Stat Fees

without calling BCOL_API quantity times.

BC Online only charges 1 service fee, because the quantity isn't sent over?

seeker25 avatar Nov 04 '22 19:11 seeker25

bcol_service in sbc_pay sends the total amount ( sum of all the total from all line items which is the total excluding service fee ) to BCOL_API. We do not send any quantity with it, though it seems they BCOL_API can accept a parameter for it.

Actions Items:

  1. Check with Patty to figure out the behaviour if quantity is passed in the API call ( say 2 ). If this result in the correct calculation of the service fee, then bcol_service will need to be modified to account for the rate and amount accordingly.

ritvick avatar Nov 07 '22 22:11 ritvick

bcol_service in sbc_pay sends the total amount ( sum of all the total from all line items which is the total excluding service fee ) to BCOL_API. We do not send any quantity with it, though it seems they BCOL_API can accept a parameter for it.

Actions Items:

  1. Check with Patty to figure out the behaviour if quantity is passed in the API call ( say 2 ). If this result in the correct calculation of the service fee, then bcol_service will need to be modified to account for the rate and amount accordingly.

@ritvick, has this been initiated with Patty?

daniwilliamson avatar Nov 08 '22 21:11 daniwilliamson

@ritvick, I will be out of the office on Monday and Tuesday, but if you could provide an update, I have asked Dwayne Gordon to pass along the update to the folks with Court Services. Thank you!

@DJ-Gordon

daniwilliamson avatar Nov 11 '22 03:11 daniwilliamson

Duplicated by https://github.com/bcgov/entity/issues/4677

seeker25 avatar Nov 15 '22 15:11 seeker25

Hi @seeker25 and @ritvick, Would you please provide a status update for this issue with respect to Court Services Online (CSO)? The partner is pressing for an update as this data is critical to Attorney General's month end financial reconciliation.

daniwilliamson avatar Nov 16 '22 19:11 daniwilliamson

I've reverted the changes on DEV/TEST. Jaime and Patty are going to go through this.

seeker25 avatar Nov 23 '22 00:11 seeker25

Waiting on the business to make a decision for this - then Jaime will make changes to make this work hopefully.

seeker25 avatar Nov 28 '22 20:11 seeker25

This will need to be updated on PROD, when the time comes:

image.png

$1 because we want the fee calculation to be right when querying the fees.

seeker25 avatar Dec 02 '22 21:12 seeker25

I think we're waiting for Jaime to implement this as well, before moving it to prod.

seeker25 avatar Dec 06 '22 16:12 seeker25

@AshnaMehta all transactions with quantity, should only charge a single transaction fee now.

Previously we had some code in there for CSO that it would multiply the service charge.

We don't have access to CSO's website on DEV/TEST, so might need to craft a postman request to test this out.

seeker25 avatar Dec 06 '22 16:12 seeker25

Sent over screenshot closing

seeker25 avatar Dec 06 '22 20:12 seeker25