entity icon indicating copy to clipboard operation
entity copied to clipboard

Update Confirm Incorporation Agreement and Article Completion

Open severinbeauvais opened this issue 3 years ago • 4 comments

  • [ ] update for CCC, ULC and BC (LTD)

Should be:

image.png

But is currently:

image.png

severinbeauvais avatar Nov 02 '22 18:11 severinbeauvais

@yuisotozaki Please see screenshot of what is there currently. Is it up to date already? Please update designs accordingly.

severinbeauvais avatar Nov 02 '22 18:11 severinbeauvais

What's in the design currently is BEN version. Will add more versions as they become available.

yuisotozaki avatar Nov 03 '22 16:11 yuisotozaki

This ticket is blocked until we have the final content for the new types, ULC, CCC and BC

Mihai-QuickSilverDev avatar Nov 04 '22 17:11 Mihai-QuickSilverDev

When the requirements and UI design are unblocked, please move this ticket to the Sprint Backlog and current sprint.

severinbeauvais avatar Nov 07 '22 18:11 severinbeauvais

Description updated with input from policy. Still awaiting updated sample incorporation agreement. There will be 3 versions: BC Benefit Company, BC Limited Company, and BC CCC.

yuisotozaki avatar Nov 14 '22 21:11 yuisotozaki

  • [x] Update the value being passed when Sample is selected. Currently 'Table-1' is being passed.

jdyck-fw avatar Nov 16 '22 17:11 jdyck-fw

The UI changes for the incorporation agreement step.

Numbered Ben UI changes.png

numbered limited ui changes.png

ccc numbered UI changes.png

Ulc numbered UI changes.png

lambert-alex avatar Nov 18 '22 20:11 lambert-alex

@lambert-alex ~Please verify that the work done in these images does not overlap with ticket 14142.~ These two tickets are duplicates and 14142 has been closed. Please continue the work in this ticket.

lewischenstudio avatar Nov 18 '22 20:11 lewischenstudio

Please add a release to this ticket.

severinbeauvais avatar Nov 23 '22 20:11 severinbeauvais

From stand up today the agreement files are already in dev and they are suitable as placeholders until the new agreement pdfs are created. Also 14285 covers the work for new agreement pdfs.

So I think we can unblock this ticket and move it along.

lambert-alex avatar Nov 24 '22 17:11 lambert-alex

Findings in dev pertaining to this ticket.

  1. There were errors in the original PDF filenames. They all should have "..._incorporation_agreement.pdf" rather than "..._corporation_agreement.pdf".
  2. For CCC, step 3 should only contain the custom one with a checkbox.

yuisotozaki avatar Nov 25 '22 18:11 yuisotozaki

Okay will update pdfs and ccc

lambert-alex avatar Nov 25 '22 19:11 lambert-alex

@yuisotozaki the requested changes have been made.

lambert-alex avatar Nov 25 '22 20:11 lambert-alex

Item 2 is good to go.

As for the PDF filenames for BEN, BC LTC, ULC, and CCC, I'm still seeing incorrect file name being downloaded. image.png

yuisotozaki avatar Nov 25 '22 23:11 yuisotozaki

Sorry Yui I was a bonehead and I fixed the double underline between company and corporation but not the incorporation part. 🤦‍♂️ It is good now!

lambert-alex avatar Nov 28 '22 17:11 lambert-alex

Checked in dev, ready for QA.

ethantspitt avatar Nov 28 '22 19:11 ethantspitt