entity icon indicating copy to clipboard operation
entity copied to clipboard

PAY-API - Incorrect amount charged if Non-zero fee, but zero service fee

Open seeker25 opened this issue 3 years ago • 1 comments

Thank you @lekshmimallika-aot for finding this one again

PAY-API - Incorrect amount charged if Non-zero fee, but "zero" service fee (column not empty):

image.png

Account didn't have any account_fees setup to override this.

FRREG was set to $40 fee, $0 service fee (with an explicit service fee in the column, not empty)

Attempting data fix for this for now, will revisit code changes later.

update fee_schedules set service_fee_code = null where service_fee_code = 'EN107' and fee_code <> 'EN107';

After running that query:

image

seeker25 avatar Oct 20 '22 17:10 seeker25

Higher estimate for extra verification due to risk of introducing new issues in live systems.

JohnamLane avatar Oct 27 '22 17:10 JohnamLane

Confirmed this is working locally and in dev. Got on a call with travis and confirmed with him as well. ~Will check test/prod and close if it works there~ test works and I am unable to test prod directly since I would need a prod users non staff/system token, but it should be the same

kialj876 avatar Nov 23 '22 18:11 kialj876