bcgov
UI - Adding Transfer Details read-only view to Review and Confirm screen
Read-only version of Transfer Details on Review and Confirm screen
- [x] Display read-only version of the Transfer Details on the review and confirm screen underneath Home Owners (as per updated design comp - Visual Design Link: https://invis.io/ZH131ANPF26K#/470050842_06A_QS-Review_And_Confirm)
- [x] Update Review and Confirm Summary section (blue bar) header to "Ownership Transfer or Change - Sale or Beneficiary" (and use correct blue header bar colour and correct home icon as per design comp)
Show/Hide Transfer Details Component
- [x] The Transfer Details component should only appear if/when users have made a change to the owners. And If user makes an owner change, (like adds a new owner), but then removes that new owner to return the owners to it's original state, then the transfer details component should go away again (removing any data entered)
Transfer Details Validations
-
[ ] The "review and confirm" button is what should trigger the side red bar/red labels and red message under the Review and Confirm button. These additional error validation items shouldn't appear as the user types more than the max character counts in the Declared Value and/or Consideration field. If user types more than the max characters in a field, just show that specific max character field validation as the user types without triggering all those other error validations. refer to design comps
-
[ ] If/when there are still errors or missing required fields in the Transfer Details component and user hits Review and Confirm, the message under the review and confirm button should say "< You have unfinished changes" as per design. refer to design comps
@RFK250 - I realized we didn't have a design for the read-only view of transfer details on the review and confirm screen so I mocked it up and made this ticket which will need to be done as part of Transfer
Okay, thanks @tlebedovich ! Good catch. I will add it to this sprint and we can estimate it at grooming tomorrow.
Hey team! Please add your planning poker estimate with Zenhub @cameron-freshworks @ChasBoucher @chdivyareddy @dimak1 @doug-lovett @owillborn
@owillborn , Does this ticket fix all the scenarios mentioned above^^? I can only see the Transfer details component read-only version on the review screen has been fixed, the remaining scenarios are still the same. Can you please take a look, thanks!!
@chdivyareddy I could comment on that.
- For Hide/Show Transfers Details there was a dependency on another ticket (which was recently completed) so I could go back and finish this functionality.
- For the Transfers Details validation, the original ticket did not include validation, so I expect another ticket for that. cc: @owillborn
Thanks for the info @dimak1 . As for the dynamic header I will address that in my next ticket.
@dimak1 @owillborn , thanks for the info...I believe we just need a separate ticket for 'Transfer details validation' then? Let me know once the other 2 scenarios are fixed, will verify them as part of this ticket, thanks!
Created #14091 for the validation
@owillborn just FYI - there is a drop show appearing on the top half of this component on the review screen - please remove. and we are also missing the light gray divider line above transfer details (currently in dev) -
@chdivyareddy Both scenarios are fixed here now, just validation needed now.
Verified!
Show/Hide Transfer Details Component
-
When the user Adds/deletes an owner from the table, then the transfer details component is displayed:
-
When the user undo/removes the changes made to the owner, then the transfer details component is hidden:
Read-only version of Transfer Details on Review and Confirm screen
- When the user unchecks the Lease/Land Ownership checkbox, it is not displayed in review screen:
