bcgov
UI - Review and Confirm Screen (attention / ref)
AC
Attn/Ref Component: GIVEN I am reviewing my transfer WHEN I want to enter an attention/ref number THEN I can see attention/ref elements AND I can enter an attention/ref number AND If the length exceeds 40 chars THEN I receive the standard max character field error message/field level error style as I type (user can type more than 40) AND if I delete the extra characters then the field error message goes away
AND
IF there is a max character error in the Attn/Ref field AND I click the Register Changes and Pay button THEN the message "< Please complete required information" appears under the button AND the user is auto-scrolled to the first component with an error AND the component will show a red vertical error line and red subhead as per design comps AND if I complete all page errors then all the error red/messages go away
AC
Confirm Component: IF the user has not checked the Confirm component check box AND I click the Register Changes and Pay button THEN the message "< Please complete required information" appears under the button AND the user is auto-scrolled to the first component with an error AND the component will show red text next to the checkbox, a red vertical error line and red side subhead as per design comps AND if I complete all page errors then all the error red/messages go away
AC
Authorization Component: IF the user has not checked the Authorization component check box AND I click the Register Changes and Pay button THEN the message "< Please complete required information" appears under the button AND the user is auto-scrolled to the first component with an error AND the component will show the text next to the checkbox as red and show a red vertical error line and red side subhead as per design comps AND if I complete all page errors then all the error red/messages go away
Hey team! Please add your planning poker estimate with Zenhub @cameron-freshworks @ChasBoucher @chdivyareddy @dimak1 @doug-lovett
@dimak1 , When the reference numbers reach the max limit, then the Max error message is displayed which is working as expected. But, 'Please make any required changes' error message is also triggered under the 'Register and Pay changes' button before clicking it. Please take a look, thanks!!
@chdivyareddy as per the last item in the AC, it should prevent us from the submission in case there are errors. My understanding was that we should show that error message (under the buttons). If it's not the case, maybe we can update the AC @tlebedovich
@dimak1 @chdivyareddy - Theses should be separate error triggers. If user errors more than the max character, just show the max character error message under the field (no red side label no red bar or red message under blue button).
If user ignores the max error field message and clicks the Register Changes and Pay button, that is when the red message appears under the button, and the user gets auto-scrolled to the first component with the error, and that's also when the red side bar and red side header also appear.
@tlebedovich thanks for the clarification. Based on this, I should probably refactor Confirm Completion section validation as well. Could you please update AC for both while I start updating validation? Thanks cc: @chdivyareddy
Added all validation errors and scroll to the first error.
However, there is a dependency on the Transfer Details validation #14091. Should we pull this in as well @mstanton1 ?
Good news - looks like it is working now and this task is unblocked. cc: @PCC199 @mstanton1
@dimak1 , When the attention/ref number which is entered in the field and Cancelled the transfer by clicking on the 'Cancel' button, then when the user starts filing another transfer, the ref number from the previous filing is auto-displayed in the field. Please take a look, thanks!!
-
When the user starts filing another transfer: Same ref number as above
-
When the attention/ref number exceeds 40 chars and the user clicks on the Register and Pay button, then the error message "< Please complete required information" is not appearing under the button. (Instead Please make any required changes message appears and disappears in a few secs). The same error message should display when Confirm Completion component is not checked:
@chdivyareddy update both issues. Fixed Attn Num from reappearing for different Transfers and updated the error message on the Review screen. PR is under review.
Also, @chdivyareddy heads up that you might see the error coming up under Summary Fee (as in the screenshot below). It is normal at the moment, and it will not be showing up before we hide the Summary Fee section (until the user makes a change) and update validations for Transfer Details. This way you can verify the error messages on both the initial and Review screens. To get to the Review screen, please make some changes in Home Owners table and then fill out the Transfers Details.
Hey @dimak1 , When the 'Attention or Reference Number' is more than 40 then Max char validation is displayed, but when the user clicks on the 'Register changes and Pay' button, error message under fee summary is populated for a sec and disappears without auto-scrolling to the component. Please take a look, thanks!
When Register changes and pay button is clicked: No error message and not auto-scrolled to the 'Attention or Reference Number' component
Hi @chdivyareddy, yes I'm able to reproduce it myself. I can see that it's trying to submit the Transfer ignoring the error in Attn Ref field. Validation issues. I will check, thanks!
@chdivyareddy I fixed the validation for the Attention Reference Number field. However, submission in my local dev env is not going thru. It could be because it is local env or maybe there are some other issues that are beyond this ticket. Once we merge PRs 1036 and 1037 and submit in Test env, we would be in a better position to tell.
Verified!
When the user clicks the 'Register changes and pay' button without completing the required component, then the user is auto-scrolled to the first component with an error and will show a red vertical error line:
-
Attention/ref number:
-
Confirm Component:
-
Authorization Component:
