entity icon indicating copy to clipboard operation
entity copied to clipboard

Duplicate serial number checking

Open RFK250 opened this issue 3 years ago • 2 comments

As a manufacturer, I want to be warned if I'm entering a serial number that's already in use so that I don't accidentally put in the wrong one and have to correct later

As staff, I want to be able to validate serial numbers against existing ones (e.g. when I'm making a correction) so that I can assure the integrity of the registry

RFK250 avatar Oct 07 '22 21:10 RFK250

@forgeuxGH5 @tlebedovich @PatrickAHeath do any of you have further info on this? It's part of the Combined MHR and PPR Search epic, which doesn't make sense. Do you know if this is a request for the Home Sections in a Registration, or some other flow? Is the validation against a serial number that has been used in the system already? Trying to figure out where this goes:)

mstanton1 avatar Nov 04 '22 23:11 mstanton1

@mstanton1 @forgeuxGH5 - If this ticket is referring to the Home Section serial numbers, we do not currently have a check in place to see whether a home section serial number entered is already in user by another MH registration.

tlebedovich avatar Nov 07 '22 17:11 tlebedovich

Sharon confirmed this is for the home sections. She noted this functionality does not currently exist but would be helpful to reduce errors. The check would need to generate a warning, but not halt users from proceeding.

Enhancement label has been added as these items can be considered at a later time.

mstanton1 avatar Nov 17 '22 19:11 mstanton1

I think we discussed this but I don't remember the exact outcome. Are we saying we would check any serial number being entered against all serial numbers ever having been used in MHR? (the description makes it seem like that) Or just checking against ones previously used by the manufacturer registering the unit? I don't know of any rules preventing different manufacturers from using the same serial number. Or are we checking for duplicates within that registration? I know Sharon said manufacturers want to have a global "unit' serial number and then append "A", "B", etc. to the sections. But they can do that now. It could be streamlined so they wouldn't have to enter the serial prefix multiple times.

forgeuxGH5 avatar Nov 18 '22 01:11 forgeuxGH5

I understood it to be checking any serial number entered against all serial numbers ever used but would be keen to refine the ticket with Sharon if we opt to do this. Given this is a pure enhancement and we have limited information to understand the value or need I'd rather we leave this for later. I'm considering reviewing the items in the existing epics for search and creating one to hold these types of item so we don't lose sight, but can also drive towards completing what's needed for MVP.

mstanton1 avatar Nov 18 '22 16:11 mstanton1

Yeah - if it is a check on all serial numbers ever I'm not sure on the added value.

forgeuxGH5 avatar Nov 18 '22 16:11 forgeuxGH5