bcgov
After cancelling the payment of Upgrade Priority of a NR, the Upgrade Priority of the NR is still available but cannot be paid.
After cancelling the payment of Upgrade Priority of a NR, the Upgrade Priority of the NR is still available but cannot be paid.
steps to reproduce the error:
- create a NR and paid
- click "Upgrade Priority", click "Continue to Payment", and go to credit card payment page
- cancel the payment,
- click Upgrade Priority again,
- click Continue to Payment, the credit card payment page won't show up as usual.
An error {"message":"Name Request 2264911 encountered an error"} is found from DevTools. The error from log (clicking Continue to Payment): 2022-09-07 22:27:41,207 - namex - ERROR in payment:payment.py:249 - handle_payment_response: Error with status code. Actual status code: DELETED
I am able to continue renewal after cancelled. When cancelling the payment for a nr renewal, the invoices.invoice_status_code='CREATED' When cancelling the payment for a nr upgrade, the invoices.invoice_status_code='DELETED', which causing no more upgrade can be paid.
looks like a payment issue to me.
@eve-git I will move this to our grooming pile. Are you able to comment about how many times this has happened in production? If it's happening lots, that will raise the priority.
Note that it may end up as a Name Request change if it turns out the NR is responsible for choosing the correct Invoice to pay for. e.g. the cancellation correctly triggers the deletion of that invoice, but then it's incorrect for the UI to try and re-use that invoice.
I found the bug when testing duplicate payments. No bug reports from business so far. I don't think it is a high priority issue.
@eve-git Thanks for the background. I've added it to bugs for review/estimates.
@JohnamLane did you create a new ticket for your team to lookat. if so, should we close this ticket @eve-git @PCC199
This is in the Relationships backlog @ozamani9gh ..we will be using this ticket to fix the issue.
This is more likely an error in NameRequest or the NameX API as that is what requests a new invoice/payment to be created. There was some work done, or at least on the boards, to allow an NR to be used if paid for, but had an outstanding Priority upgrade that was cancelled or not needed as the Examiner approved the NR. This isn't a payment service issue
@ozamani9gh Upon completing the SRE release to Prod, please close this ticket.
@PCC199 @pwei1018 @eve-git we will need to reopen this ticket and fix the bug, @mengdong19 is reporting more of these upgrades and reapplies issues happening in PROD
@ozamani9gh I don't think they are the same issue. The bug in this ticket occurs when requesting an new upgrade after an upgrade payment cancelled.