entity icon indicating copy to clipboard operation
entity copied to clipboard

UI - Location Types + Legal Descriptions

Open RFK250 opened this issue 3 years ago • 3 comments

Description

Finishing up Location Types section:

  1. When a user registers a manufactured home on a reserve location, user will need to provide the band name, number and added details

  2. When a user registers a manufactured home to a location, in limited circumstances they may not have a PID number. E.g.:

  • The lot at the civic address is new enough that it hasn't been assigned a PID yet
  • The lot is at a mining site or crown land with no PID

In those cases, they have to enter a combination of fields known collectively as a "legal description" (e.g. Lot, Block, Parcel, Section, District Lot, etc). There is no set standard for what must be in a legal description - it could be any combination of those values. NOTE: MINIMUM REQUIRED FIELDS STILL TO BE CONFIRMED

AC

GIVEN I need to enter location information for an Indian reserve WHEN I navigate to Step 4 -> 1. Location Type -> Other Land -> Indian Reserve THEN I am able to enter the Band name, number and additional details (with validations) AND I am able to enter other legal description fields AND this information will also appear on the review and confirm screen as read only

AC

GIVEN I need to enter location information by way of a legal description WHEN I navigate to Step 4 -> 1. Location Type -> Other Land -> Strata OR Other AND I have not provided a valid PID THEN I am able to click on "I don't have a PID Number, I need to enter a Legal Description" THEN the "I don't have a PID.." link goes away AND the Additional Description field slides down THEN I am able to enter legal description data (with validations) AND this information will also appear on the review and confirm screen as read only

AND IF I have provided a valid PID THEN provide the user with user feedback (the legal description pulled in via LSTA as a string) indicating that it is a valid PID AND I am also able to add optional additional description text AND this information will also appear on the review and confirm screen as read only

AND IF the PID number look up is unsuccessful THEN show the PID error modal with updated text and contact information (see design)

NOTE: See design comps for additional AC details


See Design Ticket has all of the variations and details

https://app.zenhub.com/workspaces/design-team-space-6144b1bb15dbac0013e68828/issues/bcgov/entity/13473

RFK250 avatar Jul 26 '22 18:07 RFK250

All these legal description fields:

  • Lot
  • Parcel
  • Block
  • District Lot
  • Part of
  • Section
  • Township
  • Range
  • Meridian
  • Land District
  • Plan
  • Except Plan
  • Additional Description

Staff Screens: Screen Shot 2022-08-02 at 11 44 14 AM

Paper Form: Screen Shot 2022-08-08 at 2.05.58 PM.png

tlebedovich avatar Aug 08 '22 21:08 tlebedovich

@mstanton1 - please provide the minimum required fields when entering a legal description manually for Staff

tlebedovich avatar Nov 02 '22 23:11 tlebedovich

@tlebedovich we've discussed today, and I raised it through PO Sync. The minimum requirements for staff will match the minimum requirements for end users as per the document that Scott shared with me. Thanks!

mstanton1 avatar Nov 04 '22 23:11 mstanton1

@mstanton1 - i updated the description above based on our updated designs.

tlebedovich avatar Nov 09 '22 21:11 tlebedovich

Thank you @tlebedovich!!!

mstanton1 avatar Nov 10 '22 16:11 mstanton1

@forgeuxGH5 - I am out of time and my IDIR just expired so that is the universe saying that will need you to UXA this full story please. Design comps to refer to is in the ticket info above. Thank you!

tlebedovich avatar Dec 14 '22 00:12 tlebedovich

@cameron-eyds - Here is the in progress UXA (cannot UXA the PID entry until it's working) but you could get started on these items in the mean time:

Input Screen Text/typo updates:

  • [x] PID for Strata/Other needs to be capitalized: Screen Shot 2023-01-04 at 2.11.50 PM.png

  • [ ] Intro for Indian Reserve, Strata and Other should read "Enter as much of the legal land description as you have." Missing second "as"

  • [x] Indian Reserve should read "Band Name and Reserve Number are required."

Screen Shot 2023-01-04 at 1.48.58 PM.png

  • [x] Indian Reserve errors - remove capitalization here:

Screen Shot 2023-01-04 at 1.57.58 PM.png


PID Error modal

  • [x] Victoria Phone number does not match design comps?

Screen Shot 2023-01-04 at 2.13.39 PM.png


Indian Reserve Review and Confirm Screen:

  • [x] Adjust list order for all manually-entered legal land description values as per Melissa's list comment below (read-only text on the review screen only - input form stays as is)

  • [x] Missing white space between Band Name/Reserve Number and the other optional fields:

Screen Shot 2023-01-04 at 2.03.42 PM.png

  • [x] As soon as the user enters data into one or more manual legal description fields, then show the 2 required subheads Band Name and Reserve Number (show "Not Entered" if one or both required fields haven't been entered yet) along with any other fields that may have been entered.

  • [x] I input data into all of the manual entry legal description fields and a number of them never appear on the Review and Confirm screen.

Screen Shot 2023-01-04 at 3.02.44 PM.png


Strata Review and Confirm Screen:

  • [x] Adjust list order for all manually-entered legal land description values as per Melissa's list comment below (read-only text on the review screen only - input form stays as is)

  • [x] For some reason "Block" is appearing when not entered. Only the required fields should be showing as "Not Entered" on the review screen. All of the other fields should only appear if/when info is entered in them.

Screen Shot 2023-01-04 at 2.19.04 PM.png

  • [x] As soon as the user enters data into one or more manual legal description fields, then show the 3 required Strata subheads Strata Lot, Land District and Strata Plan (show "Not Entered" if one or all required fields haven't been entered yet) along with any other fields that may have been entered.

  • [x] I input data into all of the manual entry legal description fields and a number of them never appear on the Review and Confirm screen.

Screen Shot 2023-01-04 at 2.57.04 PM.png


Other/Other Review and Confirm Screen:

  • [x] Adjust list order for all manually-entered legal land description values as per Melissa's list comment below (read-only text on the review screen only - input form stays as is)

  • [x] Since there are 2 combos for required fields, only show subheads for any fields that have been entered (whether they are required or not)

  • [x] When required fields aren't entered, we still need to show the other field info that was entered

  • [x] I input data into all of the manual entry legal description fields and a number of them never appear on the Review and Confirm screen.

  • [x] Since there are 2 combos for required fields, do not highlight any required field-level errors for Other, only highlight the required field instructional text (and turn the red off as soon as the user has fullfilled one of the 2 required combos):

Screen Shot 2023-01-04 at 3.08.18 PM.png

  • [x] The required field instructional text should not stay highlighted red if the user has entered at least one of the two required combos. In this case, that instructional text should not be red:

Screen Shot 2023-01-04 at 3.41.18 PM.png


PID/LTSA Look Up UXA:

  • [ ] Can we add commas (with single space after each) between items so it's easier to read like BC Assessment does? TL: Not required for now

  • [ ] I noticed our LSTA look up information is missing some of the data and in a different order than what's on shown on the BC Assessment PID look up. TL: Not required for now - doug may review

Can we confirm we are pulling in everything we should and it's displaying in the correct order (you may need to chat with Melissa/Doug)? Examples:

Screen Shot 2023-01-10 at 5.15.24 PM.png

Screen Shot 2023-01-10 at 5.31.13 PM.png

  • [x] Small spacing adjustment - set bottom margin to 20px instead of 12px here:

Screen Shot 2023-01-10 at 5.12.40 PM.png

tlebedovich avatar Jan 04 '23 23:01 tlebedovich

@tlebedovich I've received confirmation that the order for display of a legal land description does not actually align with our component in the UI. Keep input form screen order as is but for the Review and Confirm read-only screen and PDF outputs the order of the legal land description should be:

image.png

Lot Parcel Block District Lot Part Of Section Township Range Meridian Land District Plan Except Plan Additional Description

cc @doug-lovett @cameron-eyds @forgeuxGH5

mstanton1 avatar Jan 05 '23 16:01 mstanton1

@mstanton1 - UXA comments are good to go here now. Still waiting to do UXA for PID LTSA look up since it wasn't working. I don't think there is a dev assigned to this since it was done at the story level. A dev could start on the feedback above and then I could add additional UXA for LTSA look up once it's working.

tlebedovich avatar Jan 06 '23 01:01 tlebedovich

I can pick up the UXA updates when i have capacity 👍

cameron-eyds avatar Jan 06 '23 15:01 cameron-eyds

Putting this story back into 'In Progress' to give some visibility to the UX updates happening under this ticket.

cameron-eyds avatar Jan 09 '23 23:01 cameron-eyds

fyi @cameron-eyds - I will UXA the LSTA look up tomorrow and add in any additional notes.

tlebedovich avatar Jan 10 '23 00:01 tlebedovich

@tlebedovich Sounds good, thanks!

cameron-eyds avatar Jan 10 '23 15:01 cameron-eyds

@tlebedovich With regards to the Error Contact Phone Number, this was a recently requested change. Ticket ref: https://app.zenhub.com/workspaces/assets-team-space-61426544e7e2ea001d079597/issues/gh/bcgov/entity/14712

cameron-eyds avatar Jan 10 '23 16:01 cameron-eyds

@cameron-eyds - ok, good to know about the number thanks. I added a few comments about LTSA. @mstanton1, can you have a look at the mismatch our LTSA data and what I see on BC Assessment PID lookup data - I assumed they would be pulling the same data in? Ours is missing the land district name and some other details and in a different order.

tlebedovich avatar Jan 11 '23 01:01 tlebedovich

@tlebedovich Few comments with regards to the LTSA look up. We display exactly what is returned from LTSA request with zero manipulation, so if there is suspicion we are missing something, it would be missing on their end as well. Not sure if they do any manipulation in their UI.

Also, along the same lines, we 'can' add commas in but the string is just a run on description, our UI has no way of interpreting exactly where the commas should go. If we did it after each word alone, it would end up like the picture seen below.

Screen Shot 2023-01-11 at 1.31.57 PM.png Screen Shot 2023-01-11 at 1.40.51 PM.png

cameron-eyds avatar Jan 11 '23 21:01 cameron-eyds

@cameron-eyds - ah ok. random commas would not be a good thing so its look a run on description it is. And ok re: data being pulled, thanks for looking into both.

tlebedovich avatar Jan 11 '23 21:01 tlebedovich

@tlebedovich Absolutely, no prob! Doug may have some ideas, however i'm just not sure if there is anything we could do that would be reliable in all instances.

cameron-eyds avatar Jan 11 '23 21:01 cameron-eyds

@cameron-eyds - Looks great. One of my favourite components. one tiny item - I will move this along to RFQA, but please do this is your current ticket if you can:

the second "as" word was missed for the 3 intros - should be "Intro for Indian Reserve, Strata and Other should read "Enter as much of the legal land description as you have."

tlebedovich avatar Jan 16 '23 19:01 tlebedovich

@tlebedovich Wonderful, thanks :)

Absolutely, will update in my current commit 👍

cameron-eyds avatar Jan 16 '23 19:01 cameron-eyds

Verified the changes in TEST except the tiny word missing 'as' in the intro for Indian Reserve, Strata and Other. Will verify once the change is in, moving this ticket along, thanks!!

chdivyareddy avatar Jan 18 '23 19:01 chdivyareddy