entity icon indicating copy to clipboard operation
entity copied to clipboard

Enable Searching/filtering for Pending and Rejected accounts

Open zac-broitman opened this issue 4 years ago • 6 comments

  • As a staff member
  • I want to search/filter the accounts in the Pending and Rejected lists of account submissions
  • so that I can find the account I am looking for more easily

Acceptance Criteria

Scenario 1: Searching in the Pending section

  • GIVEN ... the user is a staff member
  • WHEN ... they view the list of Pending accounts
  • THEN ... they should be able to search/filter in each column

Scenario 2: Searching in the Rejected section

  • GIVEN ... the user is a staff member
  • WHEN ... they view the list of Rejected accounts
  • THEN ... they should be able to search/filter in each column

zac-broitman avatar Jan 18 '22 23:01 zac-broitman

It will be taken care as part to Business search

SateeshFW avatar Mar 17 '22 17:03 SateeshFW

Bumping this ticket up, UX wants range datepicker, originally I thought we could just sort by the date Also.. need to fetch all the products and have them display as part of the box.

seeker25 avatar Oct 27 '22 20:10 seeker25

  • [ ] Date filter is not including end date. I searched June 23, 2022 - July 6, 2022, and the 3 submitted on July 6 (in test) did not show up.

  • [ ] Strange retention of values on the page count. Before filtering image.png

After filtering image.png

  • [ ] Not sure if it was part of this ticket, but I would expect to be able to sort the list as well. Should this be a separate ticket?
  • [ ] Clear filters doesn't fully clear the date picker. The filter is removed and everything is shown again, but if I open the date picker again, it retains the previous values.

janisrogers avatar Nov 07 '22 18:11 janisrogers

I'll fix the end date issue ~for date filtering not including end date, was June 23, 3033 the start date or end date? I can't seem to log into dev or test to verify myself right now with my IDIR.~

~Currently if start date is later than end date it'll show nothing. Do you want that changed so that in these cases we default to filtering for accounts with submitted dates that are on the end date?~

MatthewCai2002 avatar Nov 07 '22 18:11 MatthewCai2002

June 23 was start date, July 6 was end date. I would expect it to include everything submitted on June 23 - July 6, including the start and end dates.

janisrogers avatar Nov 07 '22 19:11 janisrogers

Probably an issue with UTC dates.

seeker25 avatar Nov 08 '22 01:11 seeker25

@janisrogers sorting is not part of this ticket.

lmallika86 avatar Nov 08 '22 19:11 lmallika86

@janisrogers ~Another point has come up regarding this ticket.. All the dates shown are in UTC.. so it's confusing~

I'm wrong they're in PST

I think we should display the times in Pacific timezone, that way if someone does an action at

4 pm on the dot, it doesn't count as a new day (Don't forget this would change during daylight savings as well, to 3 pm when we goto -7)?

image

image

The date filters I expect should cover from Midnight of the start - to the very end of the day of the end date

2022-01-01 00:00:00 PST to 2022-01-02 11:59:59 pm PST

seeker25 avatar Nov 10 '22 15:11 seeker25

@seeker25 I agree the time should be Pacific Time.

janisrogers avatar Nov 10 '22 16:11 janisrogers

  • [x] Date filter is not including end date. I searched June 23, 2022 - July 6, 2022, and the 3 submitted on July 6 (in test) did not show up.

  • [x] Strange retention of values on the page count.

  • [x] Clear filters doesn't fully clear the date picker. The filter is removed and everything is shown again, but if I open the date picker again, it retains the previous values.

seeker25 avatar Nov 15 '22 19:11 seeker25

@janisrogers should be fixed now in DEV - maybe give it a once over?

over to you @AshnaMehta

seeker25 avatar Nov 15 '22 19:11 seeker25

Pushed to prod

seeker25 avatar Nov 16 '22 23:11 seeker25