bcgov
bc2pg postgres table creation - add precision to numeric types
Data types for numbers in Oracle are generally described by the catalogue api in format 'data_type': 'NUMBER', 'data_precision': '4'.
The precision is not currently used when creating output table in postgres, bc2pg writes all NUMBER columns to a generic NUMERIC type as defined by sqlalchemy, with no precision (despite what comment says, perhaps this is something that was removed)
https://github.com/smnorris/bcdata/blob/main/bcdata/database.py#L156
This is not an issue when working with the data in postgres, but on dumping to other formats the type guessing can be problematic - it would probably be better if the postgres type is better defined.
Yes, this was tweaked with https://github.com/smnorris/bcdata/issues/117 https://github.com/smnorris/bcdata/commit/67bde22c0f5c90aa9841de391ad1dc12bf5ee390
A better NUMBER -> NUMERIC lookup is needed. https://aws.amazon.com/blogs/database/convert-the-number-data-type-from-oracle-to-postgresql-part-1/