Bryan Boreham
Bryan Boreham
Two PRs languished for ~5 months, which is not good. Perhaps we could have an explicit list of maintainers, and an instruction to @-mention them to gain attention?
This would have picked up the issue in #70 For instance: ``` $ go test -tags 'peer_name_hash peer_name_alternative' # github.com/weaveworks/mesh ./peer.go:50: name.bytes undefined (type PeerName has no field or method...
Original message from https://github.com/weaveworks/weave/issues/1763: "SurrogateGossiper does not (and cannot) know how to merge GossipData, so instead it just stashes it in a queue. That is potentially unbounded since downstream connections...
Many objects have Conditions, like these on a Deployment: ``` conditions: - lastTransitionTime: "2021-03-01T17:21:28Z" lastUpdateTime: "2021-03-01T17:21:28Z" message: Deployment has minimum availability. reason: MinimumReplicasAvailable status: "True" type: Available - lastTransitionTime: "2020-11-24T13:37:06Z"...
Evidently `golangci-lint` isn't doing it, as seen at #19
Filing this issue as a place-holder / reminder for myself. Grafana Tempo is a trace store that does not index span tags, so the workflow I used with Jaeger doesn't...
Example:  I think this is really a bug in Kubernetes where the `source` field is set, but we probably have to deal with it in Kspan anyway. Event details...
Seems to be looping here: https://github.com/weaveworks-experiments/kspan/blob/3e8e909978e9a07a2765aae795514f508566da2b/controllers/events/outgoing.go#L46-L54 Could a span have a parent that points at itself? goroutine dump: ``` SIGQUIT: quit PC=0x46d7c1 m=0 sigcode=0 goroutine 0 [idle]: runtime.futex(0x22f5428, 0x80, 0x0,...
When the Weave Net DaemonSet first installs on a node, it writes out CNI binaries and configuration into the host filesystem. Mount those directories closer to where they are needed...
Motivation for this change is at https://github.com/grafana/mimir/issues/285#issuecomment-1029143100, where a large program spends 12% of its CPU in this one function. Re-coded `scanGetResponseLine()` using `IndexByte()` instead of `SScanf()`. Also added a...