Bryan Boreham comments

Results 1068 comments of


                                            Bryan Boreham

Remove vendoring from addon-resizer; update Go version

Thanks, I was indeed missing that context.

Rule: Add Grouplabels to Group struct

I find this change believable, but would like @clwluvw to comment. How did your change work without this?

Rule: Add Grouplabels to Group struct

>I guess i was only interested in the labels we construct here: Right, I can't see how `rg.Labels` would be populated before that line. What am I missing?

Rule: Add Grouplabels to Group struct

OK thanks. So why doesn't that work for Thanos? Why do we need it in two more structs @coleenquadros ?

Eager compaction of stale series

Note that head-compaction bypasses isolation, because it knows that samples cannot be added inside the compaction window. This is implemented in `appendableMinValidTime` by assuming that compaction starts half-way through the...

gate: add metric for wait

[Reviewed at the bug-scrub] The counter added here will let observers see the rate with which total waiting time is increasing. This does not seem to address the request in...

gate: add metric for wait

I think the code has been substantially changed since I last looked at it; I don't think it matches the PR description any more. I don't think I should be...

gate: add metric for wait

I think we should close this then. To be clear: I'm not saying this PR is bad, but as a reviewer I couldn't see how it would be used, and...

Way to convert k8s configmap to metrics or logs with Alloy

Or we could get Cluster Autoscaler to output the desired metrics directly. * https://github.com/kubernetes/autoscaler/issues/5850

UTF-8: Implement quoting and escaping in UI autocompletion

Hello from the bug-scrub! @juliusv can you offer any help to @sujalshah-bit ?