Bryan Boreham comments

Results 1068 comments of


                                            Bryan Boreham

TSDB: Lock around access to labels in head under -tags dedupelabels

/prombench main

TSDB: Lock around access to labels in head under -tags dedupelabels

That seems to have had the desired effect.

TSDB: Lock around access to labels in head under -tags dedupelabels

/prombench cancel

TSDB and scraping: improvements to dedupelabels

Force-pushed to fix merge conflicts and squash intermediate commits.

Default enable-feature flag to no-default-scrape-port

I fixed up the commits, but it is still doing the less-desired thing.

Default enable-feature flag to no-default-scrape-port

I took a look round the targets on a Prombench instance of Prometheus. All of them appeared to have a port supplied via service discovery or via config. My understanding...

promql: sort_by_label should fallback to a consistent ordering by metric, not by sample value

I can't think how it can happen that two series have the same label value. The PromQL engine checks between each operation and halts with an error if it finds...

promql: sort_by_label should fallback to a consistent ordering by metric, not by sample value

Oh, my mistake - it sorts by a subset of labels, which can have the same value.

kubernetes-sd: expose status.PodIPs / podMonitor support IP family

Hello from the bug-scrub! @DrAuYueng are you still interested in this feature?

[meta] Remote Write 2.0 Spec Feedback List

Hello from the bug-scrub! Should we close this as RW2 was shipped with Prometheus 3 ? @bwplotka