Bryan Boreham

Results 1068 comments of Bryan Boreham

I looked at the package; you need to call `.Format(expfmt.FmtText)` to meet the expectations of this program (documented [here](https://github.com/weaveworks/prom-aggregation-gateway/tree/123c6bfc5e07fb8f118c19b3281855bcb2463c39#how-to-use)). I filed https://github.com/prometheus/client_golang/issues/824 for the inconsistency.

Interesting. That code is mostly from the Prometheus `expfmt` library; maybe we're using it wrong?

Hi, thanks for the PR, and sorry it languished for a bit. It's quite big (at least superficially) so may take a while longer to figure out what changed. I...

I notice the Prometheus Pushgateway has a similar feature, but the labels form part of the http path - see https://github.com/prometheus/pushgateway#url . Would that work for you? It would be...

OpenTracing has been deprecated for nearly a year; why wouldn't you just switch to OpenTelemetry? Adding abstractions over abstractions seems like an antipattern to me. There is a [bridge](https://github.com/open-telemetry/opentelemetry-go/tree/main/bridge/opentracing) for...

Maybe if you include "no dependency" as an option that becomes clearer? I.e. the abstraction would include a no-op tracer.

Where there are more than one trace IDs covered in a profile, sorting by number of samples would be useful.

> I'm curious, what's the use case for an exemplar without labels? When visualized, the values give a better idea of distribution. Especially when buckets are coarse, exemplars can suggest...

I created a feature request upstream https://github.com/prometheus/prometheus/issues/14208

> The Prometheus TSDB code drops exemplars with no labels I believe this was a misunderstanding. Nick's source is me at #873, where I said it would be confusing. I...