Bryan Boreham
Bryan Boreham
Now I think about it some more, I'm not sure we can get the same result without samples. I think in the current code it will look back the stale...
> decide what to do with examplars too far in the future Exemplars should never be newer than the sample; the point is to add detail to data that has...
This is very clear that `labels.Labels` must be sorted inside Prometheus: https://github.com/prometheus/prometheus/blob/b1566f761ef7d1c8ab6446afd017c0ce17e9224e/model/labels/labels.go#L42-L44 Another way in which behaviour will change is `Labels.Compare` will say that the same labels in different order...
Note that the current comment says “ May return the input labelSet modified.”
> Why do you disagree? It’s an implementation detail, not part of the intended contract of the function.
Note the documentation https://thrift.apache.org/lib/go tells you to get it from `github.com/apache/thrift/lib/go/thrift`. You can apply an override in your project similar to https://github.com/jenkins-x/jx/pull/3321/files
> Apparently a redirect was added That was over a year ago. Apparently it has now gone away.
I don't know whether I'll get around to it either, but could you suggest a file or function which is a good place to start looking how to add it?
I was awaiting further comment. I asked a couple of questions for clarification at https://github.com/jaegertracing/jaeger-ui/pull/703#discussion_r582821264
> more dynamic Now you mention it, before I started hacking on the code my thought was that as a user I should be able to configure by point-and-click, "when...