Bryan Boreham

I find it slightly weird that there are now four calls to `isDone()` in `sendBatches()`, three looking at `ctx` and one looking at `queryServer.Context()`. If there is a good reason...

Perhaps this could be implemented via [engineQueryFunc](https://github.com/cortexproject/cortex/blob/106aa42093a6286852fcb5cddffb6e8b978c9d1e/pkg/ruler/compat.go#L71). Limits could be integrated with the existing limit/overrides system.

Possibly addressed by prometheus/prometheus#9260

Cortex SD will resolve a DNS name into multiple targets, which makes it suitable for use with a Kubernetes "headless service", or any other mechanism which gives the same kind...

> we should be specific with the word "resolve" There are multiple cases: * calling via the "ring", for ingesters, store-gateway: by IP address as described earler in this issue....

Can we get the heap profile data please? (not a screen dump or svg)

Sorry @amckinley, missed your message. The profile shows 6GB in use, and 42GB allocated since the start of the program. This is hard to square against the symptom of 70GB,...

Thanks, that adds a bit more detail, and you managed to snap the heap at a point where in-use was high. The memory is still all being allocated by Snappy:...

@chancez that doesn't match my understanding of how Go works. You can set the environment variable `GODEBUG=gctrace=1` to get a line about each garbage-collection in the log file. Note from...

> I can believe that those have pointers into the incoming buffer Well, I checked, and we take care to blank out those pointers. Strike that theory. https://github.com/cortexproject/cortex/blob/7f85f92480a27171da4980c556c3a2d07dc30b87/pkg/ingester/client/timeseries.go#L280-L283 @amckinley I...