simorgh
simorgh copied to clipboard
DO NOT MERGE WS-464 Remove isLive check from Portrait Video
Resolves JIRA: 464
Summary
Remove isLive check from Portrait Video
This is to be merged when we are ready to conduct the experiment
Code changes
- A bullet point list of key code changes that have been made.
Developer Checklist
- [ ] UX
- [ ] UX Criteria met (visual UX & screenreader UX)
- [ ] Accessibility
- [ ] Accessibility Acceptance Criteria met
- [ ] Accessibility swarm completed
- [ ] Component Health updated
- [ ] P1 accessibility bugs resolved
- [ ] P2/P3 accessibility bugs planned (if not resolved)
- [ ] Security
- [ ] Security issues addressed
- [ ] Threat Model updated
- [ ] Documentation
- [ ] Docs updated (runbook, READMEs)
- [ ] Testing
- [ ] Feature tested on relevant environments
- [ ] Comms
- [ ] Relevant parties notified of changes
Testing
- [ ] Manual Testing required?
- [ ] Local (
Ready-For-Test, Local) - [ ] Test (
Ready-For-Test, Test) - [ ] Preview (
Ready-For-Test, Preview) - [ ] Live (
Ready-For-Test, Live)
- [ ] Local (
- [ ] Manual Testing complete?
- [ ] Local
- [ ] Test
- [ ] Preview
- [ ] Live
Additional Testing Steps
- List the steps required to test this PR.
Useful Links
- Coding Standards
- Repository use guidelines
- Add Links to useful resources related to this PR if applicable.
@holchris May be worth adding a test to the index.test.tsx file for curation. That test suite includes tests for the different components Curation can render, so would be good to add PortraitVideoCarousel to that: https://github.com/bbc/simorgh/blob/904036b39ecb8acc97d1bd52c02702670c546c99/src/app/components/Curation/index.test.tsx#L50-L86