simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

WS-134: Update addProcessClientDevice....() function to use reverb.

Open shayneahchoon opened this issue 8 months ago • 1 comments

Resolves JIRA: https://bbc.atlassian.net/browse/WS-134

IMPORTANT: This ticket should not be merged until this PR has been merged and reverb-url helper has been fully deployed to version 1.1.0, under this URL: https://mybbc-analytics.files.bbci.co.uk/reverb-url-helper/bbc-reverb-url-helper-1.1.0.tgz

Summary

Updates addProcessClientDeviceAndSendStaticBeaconToWindow() to use functionality from reverb-url helper.

IMPORTANT: Errors exist because reverb-url-helper hasn't yet been deployed to reflect the library update that includes getLiteSiteUrl that this PR uses. (This PR needs reverb-url helper V1.1.0, but currently references V1.0.2 in package.json).

Code changes

  • A bullet point list of key code changes that have been made.

Developer Checklist

  • [ ] UX
    • [ ] UX Criteria met (visual UX & screenreader UX)
  • [ ] Accessibility
    • [ ] Accessibility Acceptance Criteria met
    • [ ] Accessibility swarm completed
    • [ ] Component Health updated
    • [ ] P1 accessibility bugs resolved
    • [ ] P2/P3 accessibility bugs planned (if not resolved)
  • [ ] Security
    • [ ] Security issues addressed
    • [ ] Threat Model updated
  • [ ] Documentation
    • [ ] Docs updated (runbook, READMEs)
  • [ ] Testing
    • [ ] Feature tested on relevant environments
  • [ ] Comms
    • [ ] Relevant parties notified of changes

Testing

  • [ ] Manual Testing required?
    • [ ] Local (Ready-For-Test, Local)
    • [ ] Test (Ready-For-Test, Test)
    • [ ] Preview (Ready-For-Test, Preview)
    • [ ] Live (Ready-For-Test, Live)
  • [ ] Manual Testing complete?
    • [ ] Local
    • [ ] Test
    • [ ] Preview
    • [ ] Live

Additional Testing Steps

  1. List the steps required to test this PR.

Useful Links

shayneahchoon avatar Jun 09 '25 12:06 shayneahchoon

Nice, is the expectation going to be applying this to component click and view tracking for lite pages in the future, so we can get rid of the branching logic?

Yessss. We might need a bit of work in Simorgh to incorporate the reverb-url helper at a component level, but that shouldn't be too tricky.

shayneahchoon avatar Jun 10 '25 12:06 shayneahchoon