simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard
verified publisher icon bbc

WSTEAM1-733 Display audio on the Live Page

Open emilysaffron opened this issue 1 year ago • 2 comments

Resolves JIRA WSTEAM1-733 Overall changes

Displays audio within live page posts

Code changes

  • adds audio rendered with the MediaLoader to componentsToRender within Post
  • adds fixture data and unit test

Testing

  1. Visit http://localhost.bbc.com:7081/mundo/live/cemn2qq3x8vt?renderer_env=test and find the post with embedded audio. Observe the working audio player, make sure it looks correct and functions. (Media playing twice is a react re-rendering issue and is expected, it works fine not on local)

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

emilysaffron avatar Oct 04 '24 11:10 emilysaffron

Noticed the background colour inside of a Post, is that ok with UX? Screenshot 2024-10-04 at 15 40 22

amoore108 avatar Oct 04 '24 14:10 amoore108

Noticed the background colour inside of a Post, is that ok with UX? Screenshot 2024-10-04 at 15 40 22

good question !! will check with them

emilysaffron avatar Oct 04 '24 14:10 emilysaffron

Looks good. Is the design of the audio different to https://github.com/bbc/simorgh/pull/12031#issuecomment-2393871630? Or are UX ok with that?

amoore108 avatar May 16 '25 10:05 amoore108

Looks good. Is the design of the audio different to #12031 (comment)? Or are UX ok with that?

It looks like the background has been updated now to match the background colour of the post. I've added a UX Review subtask to the ticket, and put this code on preview 1+2 so that we can check this and all other pages which have an audio player (WORLDSERVICE-908)

karinathomasbbc avatar May 19 '25 14:05 karinathomasbbc