simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard
verified publisher icon bbc

Fixed an issue where files ended in .mdx instead of stories.mdx, this…

Open Auxy6858 opened this issue 1 year ago • 1 comments

… would cause the README as well as other files to direct to non-existent files.

Auxy6858 avatar Aug 20 '24 23:08 Auxy6858

Is anyone actually going to check this?

Auxy6858 avatar Aug 24 '24 16:08 Auxy6858

This issue still exists

Auxy6858 avatar Sep 04 '24 00:09 Auxy6858

Hi @Auxy6858

We did the renaming from .stories.mdx to .mdx as part of upgrading to Storybook 8, so we're keen not to go back if possible. Can you describe briefly what problem you're trying to solve here? I'm looking at some of the files and I can spot some 404s, but they seem unrelated and I'll get those updated.

I've had a nosy in the codebase and can see there are 2 stories.mdx links in one of our legacy dirs - https://github.com/bbc/simorgh/blob/1f30901edda9a76d8c7dd1a0f95e46f2aedb66fe/src/app/legacy/psammead/README.md?plain=1#L12-L13 - so I can get those fixed while I'm looking around anyway...

eagerterrier avatar Sep 13 '24 16:09 eagerterrier

Yes some of the links still lead to stories.mdx files, the documentation still also tells you to name files ending in stories.mdx. I'll have another look at it later.

Auxy6858 avatar Sep 13 '24 16:09 Auxy6858

👋 we're going to close this PR, as we have another PR which updates the links to the mdx files, as well as the documentation. #11987

karinathomasbbc avatar Sep 18 '24 11:09 karinathomasbbc