simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

Update dependency undici to v6.16.1

Open renovate[bot] opened this issue 1 year ago • 9 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
undici (source) 6.11.1 -> 6.16.1 age adoption passing confidence

Release Notes

nodejs/undici (undici)

v6.16.1

Compare Source

v6.16.0

Compare Source

What's Changed

New Contributors

Full Changelog: https://github.com/nodejs/undici/compare/v6.15.0...v6.16.0

v6.15.0

Compare Source

What's Changed

New Contributors

Full Changelog: https://github.com/nodejs/undici/compare/v6.14.1...v6.15.0

v6.14.1

Compare Source

What's Changed

Full Changelog: https://github.com/nodejs/undici/compare/v6.14.0...v6.14.1

v6.14.0

Compare Source

What's Changed

New Contributors

Full Changelog: https://github.com/nodejs/undici/compare/v6.13.0...v6.14.0

v6.13.0

Compare Source

What's Changed

New Contributors

Full Changelog: https://github.com/nodejs/undici/compare/v6.12.0...v6.13.0

v6.12.0

Compare Source

What's Changed

New Contributors

Full Changelog: https://github.com/nodejs/undici/compare/v6.11.1...v6.12.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Apr 08 '24 10:04 renovate[bot]

@amoore108 should we close this, as undici is being upgraded in #11266?

karinathomasbbc avatar Apr 12 '24 10:04 karinathomasbbc

@amoore108 should we close this, as undici is being upgraded in #11266?

Similar to the node-fetch update, I'd maybe just upgrade as normal for now.

amoore108 avatar Apr 12 '24 10:04 amoore108

ATI seems to be logging okay on opera mini: Screenshot_2024-04-29-11-20-16-22_81b5f59f81a9801c9f112972edbe649b

HarveyPeachey avatar Apr 29 '24 13:04 HarveyPeachey

ATI seems to be logging okay on opera mini:

Actually undici seems to be used in the nextjs app, however it looks like opera mini is surpressing console logging I've tried to inject? The preview env when visiting from Chrome on mac seems to log the fetch output of ATI, but looking at server:console in opera mini I get no output

HarveyPeachey avatar Apr 30 '24 08:04 HarveyPeachey

ATI seems to be logging okay on opera mini:

Actually undici seems to be used in the nextjs app, however it looks like opera mini is surpressing console logging I've tried to inject? The preview env when visiting from Chrome on mac seems to log the fetch output of ATI, but looking at server:console in opera mini I get no output

I get this when I visit https://www.bbc.com/pidgin on Opera Mini on my Samsung Flip 😭

Screenshot_20240507_180040_Opera Mini

karinathomasbbc avatar May 07 '24 17:05 karinathomasbbc

I get this when I visit https://www.bbc.com/pidgin on Opera Mini on my Samsung Flip 😭

Same for the preview environment - albeit it doesn't have this PR deployed at the moment, but I would expect to see something else instead of ECMAScript errors (at the very least, the error itself!)

karinathomasbbc avatar May 07 '24 17:05 karinathomasbbc

ATI seems to be logging okay on opera mini:

Was this via the Opera mini emulator, or a phone?

karinathomasbbc avatar May 07 '24 17:05 karinathomasbbc

ATI seems to be logging okay on opera mini:

Was this via the Opera mini emulator, or a phone?

This was with my Oppo android phone, I also combined debug fetch code I created here to get console debugging output. I think this dependency is only running on NextJS powered pages, as the lockfile file only references the NextJS app using it, so any page served by the express serve should be business as usual. However, when I visited a live page powered by next, I wasn't getting any console output both with this dep update, and on the latest branch

HarveyPeachey avatar May 08 '24 08:05 HarveyPeachey

I'm pretty comfortable with just merging this as as @HarveyPeachey says its just used in the Next.js app.

It'll require much more thorough testing once we do the node-fetch removal and use undici across both apps.

amoore108 avatar May 08 '24 11:05 amoore108