simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

WSTEAMA-989: Upgrade glob to 10.3.10

Open karinathomasbbc opened this issue 1 year ago • 4 comments

Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAMA-989

Overall changes

Code changes

  • Major upgrade of glob from 8 -> 10

Testing

glob is currently used for preloading fonts in storybook Storybook Permalink Check the HTML of storybook, and ensure that all fonts are declared as rel=preload

e.g.

Screenshot 2024-02-12 at 16 34 48

karinathomasbbc avatar Feb 12 '24 15:02 karinathomasbbc

Seems grand, may be worth testing on Opera Mini Extreme to make sure it works correctly?

Do you mean test Storybook on Opera Mini Extreme? Or Simorgh?

karinathomasbbc avatar Feb 14 '24 09:02 karinathomasbbc

Seems grand, may be worth testing on Opera Mini Extreme to make sure it works correctly?

Do you mean test Storybook on Opera Mini Extreme? Or Simorgh?

Simorgh probably to be the most accurate. Its tricky to know for sure until its "out in the wild" unfortunately. Just the nature of Opera Mini, it looks like it may work until its actually ran on the device.

amoore108 avatar Feb 14 '24 09:02 amoore108

Seems grand, may be worth testing on Opera Mini Extreme to make sure it works correctly?

Do you mean test Storybook on Opera Mini Extreme? Or Simorgh?

Simorgh probably to be the most accurate. Its tricky to know for sure until its "out in the wild" unfortunately. Just the nature of Opera Mini, it looks like it may work until its actually ran on the device.

Ah yes OK, that's fair. Glob is used by other dependencies, so you never know how it might affect Opera Mini.. Which also reminds me... we should probably try and write some form of test / script which will allow us to detect potential issues with Opera Mini.. not for now.

Next question... how do we test with Opera Mini Extreme - Saucelabs?

karinathomasbbc avatar Feb 14 '24 09:02 karinathomasbbc

Seems grand, may be worth testing on Opera Mini Extreme to make sure it works correctly?

Do you mean test Storybook on Opera Mini Extreme? Or Simorgh?

Simorgh probably to be the most accurate. Its tricky to know for sure until its "out in the wild" unfortunately. Just the nature of Opera Mini, it looks like it may work until its actually ran on the device.

Ah yes OK, that's fair. Glob is used by other dependencies, so you never know how it might affect Opera Mini.. Which also reminds me... we should probably try and write some form of test / script which will allow us to detect potential issues with Opera Mini.. not for now.

Next question... how do we test with Opera Mini Extreme - Saucelabs?

Yea we're looking into ways to help make Opera Mini more resilient https://jira.dev.bbc.co.uk/browse/NEWSWORLDSERVICE-1797

We tend to test on physical devices. Opera Mini Extreme can be enabled on Opera Mini on Android, so if you have Android phone you should be able to try it out. Annoyingly, the Android version is most likely not the one that is used in reality in the Hausa service. They typically use feature phones, so run a very old version of Opera.

amoore108 avatar Feb 14 '24 09:02 amoore108