simorgh icon indicating copy to clipboard operation
simorgh copied to clipboard

Use new JSX Transform

Open jroebu14 opened this issue 3 years ago • 0 comments

Supports https://github.com/bbc/simorgh/pull/10230

Overall change: Uses the new JSX Transform as described here https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html

Code changes:

  • Adds the new babel react runtime in the babel config
  • React imports removed using script from React
  • Updates a couple of large snapshots

Testing Quick regression testing checking that pages load correctly and there is no broken javascript e.g. cookie banner will appear, lazy images load.

The automated unit, integration and e2e tests all pass so we should have high confidence about these changes. Chromatic diffs look good too.


  • [ ] I have assigned myself to this PR and the corresponding issues
  • [ ] I have added the cross-team label to this PR if it requires visibility across World Service teams
  • [ ] I have assigned this PR to the Simorgh project
  • [ ] (BBC contributors only) This PR follows the repository use guidelines

Testing:

  • [ ] Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • [ ] If necessary, I have run the local E2E non-smoke tests relevant to my changes (CYPRESS_APP_ENV=local CYPRESS_SMOKE=false yarn test:e2e:interactive)
  • [ ] This PR requires manual testing

jroebu14 avatar Aug 10 '22 08:08 jroebu14