react-transcript-editor icon indicating copy to clipboard operation
react-transcript-editor copied to clipboard

Breaking change: `MediaPlayer` should be renamed `MediaControls`? `TransportControls`?

Open pietrop opened this issue 6 years ago • 2 comments

A possible breaking change suggestion, MediaPlayer (see in storybook) should be renamed MediaControls?

Since over time it has become decoupled from the actual HTML5 video player element, wrapped in VideoPlayer component, then perhaps the name should be a bit more representative?

Raising it as an issue, as it might be a breaking change for backward compatibility.

pietrop avatar Apr 23 '19 10:04 pietrop

Why not use the classic name of those things: TransportControls as seen everywhere else:

  • https://developer.amazon.com/docs/alexa-design/layout-transport-controls.html
  • https://manual.audacityteam.org/man/transport_toolbar.html

Laurian avatar Apr 23 '19 12:04 Laurian

Ah, interesting, had not seen this before, yeah, that would be a good name in line with existing conventions 👍

pietrop avatar Apr 23 '19 12:04 pietrop