genie icon indicating copy to clipboard operation
genie copied to clipboard

Game Buttons should remove accessible buttons on destroy

Open FostUK opened this issue 4 years ago • 2 comments

  • In accessibilify.js we hook into the destroy method of an event. The accessible button should also destroy itself here and clean up any arrays it is part of.
  • sys.accessibleButtons is for gameButttons and should be renamed gameButtons
  • removeButton should be removed as it is not used internally and agencies can just destroy their accessibilified game objects safely with the above changes.

FostUK avatar Aug 04 '21 10:08 FostUK

removeButton is used by storytime right?

binhbui avatar Aug 04 '21 10:08 binhbui

I guess the idea will be that future versions of Genie will make it so removeButton is not required anymore, just destroy the object and the accessibilify stuff is cleaned up automatically.

Storytime can use the old version of Genie and continue with removeButton, or update to a new version of Genie with this change in and stop calling removeButton.

AdamXA avatar Aug 04 '21 11:08 AdamXA