audiowaveform icon indicating copy to clipboard operation
audiowaveform copied to clipboard
verified publisher icon bbc

Up max sample rate to support 192kHz audio files

Open rayrrr opened this issue 8 years ago • 2 comments

Changed occurrences of 50000 max sample rate constant to 200000 (and made the same change in the tests). Functionality works as expected on 192kHz sample rate audio files at very low pixel/sample ratios.

rayrrr avatar Jan 27 '18 14:01 rayrrr

@chrisn thank you for taking the time to review this. Are you sure secondsToPixels is the var of concern here? If so I'm not sure I follow. I looked at the code and I think secondsToSamples is the var of concern, here:

https://github.com/bbc/audiowaveform/blob/master/src/GdImageRenderer.h#L82

Is that what you meant? If so I can add a test for that to this PR.

rayrrr avatar Feb 01 '18 13:02 rayrrr

ping @chrisn can we move this forward?

thijstriemstra avatar Apr 11 '19 00:04 thijstriemstra

Sorry for taking so long to reply. I ended up removing the sample rate limit entirely. You should find that the latest version works OK.

chrisn avatar Jun 04 '23 18:06 chrisn