alephant

alephant copied to clipboard

Make partials work in Alephant

3

We'd like to include common mustache templates using mustache partials. Currently by default it will look for partials in the current directory, but as we have different queues in the...

Guntrisoft

We reference BBC specific library in Example

1

``` ruby BBC::Cosmos::Config.app ``` https://github.com/BBC-News/alephant/blob/master/Example/Event-based/Renderer/app.rb#L23

Integralist

Consistent license

5

Seems the Alephant gem has a license of `GPLv3` (`GNU GENERAL PUBLIC LICENSE`), where some of the other Alephant gems are `MIT` This needs to be consistent across all gems....

Integralist

http://robm.me.uk/ruby/2014/01/18/pathname.html Will make code intent clearer (although _potentially_ at the cost of more memory)

Integralist

RSpec terminology/syntax

3

Just having a quick re-read of "The RSpec Book" and it seems that some of the test code that caused me a bit of confusion might not have if a...

Integralist

I wasn't able to add this issue to the BBC Alephant repo as that repo is forked from this one. --- https://github.com/BBC-News/alephant/blob/master/lib/alephant.rb ``` ruby def initialize(opts = {}) @sequencer =...

Integralist

Welcome to [Renovate](https://redirect.github.com/renovatebot/renovate)! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin. 🚦 To activate Renovate, merge this Pull Request. To disable...

renovate[bot]