VideoContext icon indicating copy to clipboard operation
VideoContext copied to clipboard

Video not rendered initially if not cached

Open dedurus opened this issue 5 years ago • 0 comments

Loading a page for the first time which means the video is not being cached at all returns the following error:

WebGL: INVALID_VALUE: tex(Sub)Image2D: video visible size is empty.

My hacky solution for this is adding a check for decoded video frames in updateTexture() method: https://github.com/bbc/VideoContext/blob/b59c99735be79cbf0c3db8cb6d8874afa52ee589/src/utils.js#L75-L82

Changes below:

function updateTexture(gl, texture, element) {
    if (element.readyState !== undefined && element.readyState === 0) return;

    if(element.readyState === 4 && (element.webkitDecodedFrameCount || element.mozDecodedFrames)){

        gl.bindTexture(gl.TEXTURE_2D, texture);
        gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, true);
        gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, gl.RGBA, gl.UNSIGNED_BYTE, element);

        texture._isTextureCleared = false;
    }
}

My guess is that having at least one frame decoded is enough for calculating the so called "video visible size" in the last parameter of WebGL1 texImage2D.

A note: if the page is loaded without errors, the browser has probably cached the first video frame, and the error will not be shown. To reproduce the error, please clean the browser cache first

dedurus avatar Dec 28 '20 17:12 dedurus