Fix #23

[gongzhitaao]

1. Porting to new advice syntax for crux-with-region-or-line.
2. Add parameter remove to crux-with-region-or-line allowing the user to remove such advice.

[bbatsov]

Apart from my inline comments - please capitalize the word fix in the commit messages - [Fix #23] ....

[gongzhitaao]

Actually there is a small bug in Emacs. comment-or-uncomment uses (interactive "*r\nP"), for the formatter r, if local mark ring is empty, it will show an error message The mark is not set now, so there is no region without executing the function and advice at all. kill-ring-save does not use this r formatter, so it works fine. The only work-around is to push some random mark (C-SPC C-SPC) into local mark ring before comment or uncomment some lines.

[bbatsov]

That's unfortunate. Did you report this upstream?

[dieggsy]

FWIW define-advice wraps (defun ...) (advice-add ...) and has a nice function-name@advice-name naming convention, which I think is handy if you use a completion system like helm or ivy, since searching for the original function will bring up the advice function too. So it'd be e.g. fill-region@crux-with-region-or-buffer.

[bbatsov]

@dieggsy Is define-advice some new Emacs addition?

[dieggsy]

@bbatsov Ah yeah, it's probably new to emacs 25, so it may not be a good idea to incorporate yet?