vscode-bazel icon indicating copy to clipboard operation
vscode-bazel copied to clipboard

return `default` for .sky files in getBuildifierFileType

Open arahatashun opened this issue 3 years ago • 1 comments

What

I noticed that the vscode extension's outputs for copybara configuration files are different from the CLI's output.

Why

getBuildifierFileType is out of sync with https://github.com/bazelbuild/buildtools/blob/a43aed7014c840a4c20c84958f3f15df5da780f5/build/lex.go#L125-L151

Ref

arahatashun avatar Jun 26 '22 08:06 arahatashun

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 26 '22 08:06 google-cla[bot]

@jfirebaugh Thank you. I signed the CLA. Screen Shot 2022-09-09 at 8 37 46

arahatashun avatar Sep 08 '22 23:09 arahatashun