rules_rust icon indicating copy to clipboard operation
rules_rust copied to clipboard

Add support for bzlmod

Open UebelAndre opened this issue 3 years ago • 13 comments

It would be nice if rules_rust supported bzlmod workflows. Hopefully someone familiar with that can enable that for this project.

UebelAndre avatar Aug 01 '22 19:08 UebelAndre

I don't know that much about bzlmod, but have started having a look at this. Initially I would like to simply replace rules_rust_dependencies. However, I'm having some issues. Details in #1528.

cameron-martin avatar Aug 25 '22 17:08 cameron-martin

I think it makes sense to reopen this? While the work that has been merged is great, from what I can tell there is still quite a bit of work that needs to happen to "support bzlmod" on a level that it can actually be adopted.

hobofan avatar Mar 29 '23 10:03 hobofan

Do we have a list of items that are still needed?

chrislovecnm avatar Jul 11 '23 14:07 chrislovecnm

Are loading crates via bzlmod supported in the current effort?

katre avatar Aug 01 '23 13:08 katre

Hey, Please check #2021

opicaud avatar Aug 21 '23 17:08 opicaud

Bazel 7.0 is releasing later this year, with bzlmod becoming on by default. Is anyone working to prioritize this work to align with the release of Bazel 7.0? Looks like there has been some work done in #2021.

csmulhern avatar Sep 26 '23 14:09 csmulhern

It unfortunately seems no maintainer has any experience with bzlmod at all. I've asked other members of the Bazel org to help do reviews but I unfortunately haven't seen any support. The Bzlmod changes could probably be merged as long as there's no change to existing code. For anything that needs to change, the more granular the pull-reqeusts can be the easier the rollout will be. My primary concern is that bzlmod just increases the maintenance burden by introducing a second way to to fetch dependencies. So it'd also be helpful if the changes were setup to maintain a single source of truth.

UebelAndre avatar Sep 26 '23 16:09 UebelAndre

I have scheduled some time with Bzlmod experts later this week to peer review this PR with the hope that we can move this PR forward and gain some expertise in the process.

scentini avatar Sep 26 '23 16:09 scentini

Makes sense. Thanks for the update.

I would hope long term, Bzlmod becomes the primarily supported way to fetch dependencies, though that's probably quite far in the future.

Shot in the dark, but I have tried to solicit help in this discussion thread: https://github.com/bazelbuild/bazel/discussions/18329.

csmulhern avatar Sep 26 '23 16:09 csmulhern

I have scheduled some time with Bzlmod experts later this week to peer review this PR with the hope that we can move this PR forward and gain some expertise in the process.

That sounds great, thanks @scentini. I am happy to dedicate some bandwidth in the coming month to help with contributions (though I also have no prior expertise).

csmulhern avatar Sep 26 '23 16:09 csmulhern

I have scheduled some time with Bzlmod experts later this week to peer review this PR with the hope that we can move this PR forward and gain some expertise in the process.

@scentini any updates from your meeting?

UebelAndre avatar Oct 05 '23 03:10 UebelAndre

Hi all! Any updates? I have some bandwidth to help.

chrislovecnm avatar Nov 05 '23 16:11 chrislovecnm

This needs some tlc https://bazelbuild.github.io/rules_rust/

chrislovecnm avatar Nov 05 '23 17:11 chrislovecnm