rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

feat: add requires_file attr for py_wheel

Open weixiao-huang opened this issue 3 years ago • 5 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature (please, look at the "Scope of the project" section in the README.md file)
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

weixiao-huang avatar Mar 08 '22 20:03 weixiao-huang

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar Mar 08 '22 20:03 google-cla[bot]

Any background for why this is needed? Maybe the documentation should be updated to reflect that and what's the interaction with "requires" attribute?

pstradomski avatar Mar 13 '22 11:03 pstradomski

Because sometimes we may write codes like this in setup.py

#!/usr/bin/env python

from setuptools import setup, find_packages

with open("requirements.txt") as fp:
    install_requires = fp.read()


setup(
    # get requires from file
    install_requires=install_requires,
)

However, in py_wheel, it only provides requires from bazel string. It seems we cannot get requires from files. So I add requires_file in py_wheel.

If requires specified, requires_file will not work

weixiao-huang avatar Mar 13 '22 12:03 weixiao-huang

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

github-actions[bot] avatar Sep 09 '22 22:09 github-actions[bot]

Is there any update of this PR?

weixiao-huang avatar Sep 10 '22 02:09 weixiao-huang

@weixiao-huang would you be able to rebase this and address conflicts?

UebelAndre avatar Oct 10 '22 17:10 UebelAndre

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

github-actions[bot] avatar Apr 11 '23 22:04 github-actions[bot]

@weixiao-huang knudge

chrislovecnm avatar Apr 24 '23 16:04 chrislovecnm

Sorry, I'll check it recently

weixiao-huang avatar Apr 25 '23 09:04 weixiao-huang

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

github-actions[bot] avatar Oct 22 '23 22:10 github-actions[bot]

This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

github-actions[bot] avatar Nov 21 '23 22:11 github-actions[bot]