feat: add requires_file attr for py_wheel
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
- [ ] Bugfix
- [x] Feature (please, look at the "Scope of the project" section in the README.md file)
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
- [ ] Yes
- [x] No
Other information
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
For more information, open the CLA check for this pull request.
Any background for why this is needed? Maybe the documentation should be updated to reflect that and what's the interaction with "requires" attribute?
Because sometimes we may write codes like this in setup.py
#!/usr/bin/env python
from setuptools import setup, find_packages
with open("requirements.txt") as fp:
install_requires = fp.read()
setup(
# get requires from file
install_requires=install_requires,
)
However, in py_wheel, it only provides requires from bazel string. It seems we cannot get requires from files. So I add requires_file in py_wheel.
If requires specified, requires_file will not work
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!
Is there any update of this PR?
@weixiao-huang would you be able to rebase this and address conflicts?
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!
@weixiao-huang knudge
Sorry, I'll check it recently
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!
This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"