rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

refactor: Migrate usages of `py_internal.cc_helper` to `@rules_cc`

Open hvadehra opened this issue 1 month ago • 1 comments

The builtins symbols are deleted in Bazel 9

hvadehra avatar Dec 11 '25 11:12 hvadehra

Summary of Changes

Hello @hvadehra, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort to update the Bazel build configuration by transitioning from an internal cc_helper implementation to the standard one provided by the @rules_cc repository. This change is crucial for maintaining compatibility with upcoming Bazel 9 releases, which will deprecate and remove certain built-in symbols. The modifications involve updating build file dependencies and Starlark load statements to correctly reference the external rules_cc modules, ensuring the build system remains robust and forward-compatible.

Highlights

  • Migration to @rules_cc: The pull request migrates all usages of an internal py_internal.cc_helper module to the official @rules_cc repository's cc_helper and find_cc_toolchain functionalities. This ensures compatibility with Bazel 9, which removes certain built-in symbols.
  • Removal of Internal cc_helper: The internal cc_helper.bzl file and its corresponding bzl_library definition in python/private/BUILD.bazel have been removed, streamlining the build configuration.
  • Dependency and Load Statement Updates: Various BUILD.bazel and .bzl files have been updated to reflect the new external dependencies, changing load statements and deps to point to @rules_cc modules instead of internal ones.
  • Function Call Refactoring: The py_executable.bzl file now directly calls find_cc_toolchain(ctx) from @rules_cc instead of accessing it via cc_helper.find_cpp_toolchain(ctx), aligning with the external module's API.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 11 '25 11:12 gemini-code-assist[bot]