rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard
verified publisher icon bazelbuild

refactor: toolchainize py_proto_library

Open thesayyn opened this issue 2 years ago • 2 comments

PR Instructions/requirements

  • Title uses type: description format. See CONTRIBUTING.md for types.
    • Common types are: build, docs, feat, fix, refactor, revert, test
    • Update CHANGELOG.md as applicable
  • Breaking changes include "!" after the type and a "BREAKING CHANGES:" section at the bottom. See CONTRIBUTING.md for our breaking changes process.
  • Body text describes:
    • Why this change is being made, briefly.
    • Before and after behavior, as applicable
    • References issue number, as applicable
  • Update docs and tests, as applicable
  • Delete these instructions prior to sending the PR

thesayyn avatar Nov 23 '23 21:11 thesayyn

Not ready yet; waiting for https://github.com/bazelbuild/rules_proto/pull/194 to gate this feature.

thesayyn avatar Nov 23 '23 21:11 thesayyn

fixes https://github.com/bazelbuild/rules_python/issues/1080 consequently.

thesayyn avatar Nov 23 '23 21:11 thesayyn

Okay this is green now. had to rename the workspace because https://github.com/bazelbuild/bazel/issues/18683#issuecomment-1843857373

thesayyn avatar Apr 10 '24 20:04 thesayyn