rules_python icon indicating copy to clipboard operation
rules_python copied to clipboard

Flag --incompatible_config_setting_private_default_visibility will break rules_python in Bazel 7.0

Open sgowroji opened this issue 2 years ago • 7 comments

Incompatible flag --incompatible_config_setting_private_default_visibility will be enabled by default in the next major release (Bazel 7.0), thus breaking rules_go. Please migrate to fix this and unblock the flip of this flag.

---> Note that this was not an issue until build #1349 and has been failing from #1351 onwards.

The flag is documented here: https://github.com/bazelbuild/bazel/issues/12933.

Please check the following CI builds for build and test results:

Never heard of incompatible flags before? We have documentation that explains everything. If you have any questions, please file an issue in https://github.com/bazelbuild/continuous-integration.

sgowroji avatar May 19 '23 10:05 sgowroji

Hi @chrislovecnm, Could you please look in to this issue.Thanks!

sgowroji avatar Jun 19 '23 04:06 sgowroji

https://github.com/bazelbuild/rules_python/pull/1283 is the only place that I see problems with that flag. Please let me know if that upgrade fixes the problem.

chrislovecnm avatar Jun 20 '23 19:06 chrislovecnm

@sgowroji can we close this issue?

chrislovecnm avatar Jul 11 '23 16:07 chrislovecnm

I'm closing; I believe this is fixed.

chrislovecnm avatar Aug 07 '23 18:08 chrislovecnm

But we are still seeing few errors https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/1608#0189d2b2-f127-4378-a10b-6a39bd60911e

ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/6fa682abed4ae69553486804e0da2756/external/io_bazel_rules_go/BUILD.bazel:106:10: in go_config rule @io_bazel_rules_go//:go_config: target '@io_bazel_rules_go//go/private:stamp' is not visible from target '@io_bazel_rules_go//:go_config'. Check the visibility declaration of the former target if you think the dependency is legitimate
(01:27:49) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/6fa682abed4ae69553486804e0da2756/external/io_bazel_rules_go/BUILD.bazel:106:10: Analysis of target '@io_bazel_rules_go//:go_config' failed
(01:27:49) ERROR: Analysis of target '//python:python_test' failed; build aborted: Analysis failed

sgowroji avatar Aug 08 '23 15:08 sgowroji

This is in rules_go let me make sure that we have the latest version

chrislovecnm avatar Aug 08 '23 15:08 chrislovecnm

This issue has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

github-actions[bot] avatar Feb 04 '24 22:02 github-actions[bot]

This issue was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

github-actions[bot] avatar Mar 06 '24 22:03 github-actions[bot]