rules_nodejs icon indicating copy to clipboard operation
rules_nodejs copied to clipboard

fix(builtin): properly quote env vars passed to nodejs_binary

Open kormide opened this issue 3 years ago • 0 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature (please, look at the "Scope of the project" section in the README.md file)
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Environment variables passed to the launcher script were not escaped.

What is the new behavior?

Properly surrounded in quotes as is done elsewhere.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

kormide avatar Sep 21 '22 23:09 kormide