rules_nodejs icon indicating copy to clipboard operation
rules_nodejs copied to clipboard

feat(create): introduce `--workspaceDir` flag

Open mgred opened this issue 3 years ago • 1 comments

users now can set a different name for the directory to create a workspace in

the behaivior also changed, so it is possible to create a workspace e.g. in the current dir

PR Checklist

  • [x] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Feature (please, look at the "Scope of the project" section in the README.md file)

What is the current behavior?

Users cannot set a different directory name when creating a new workspace.

What is the new behavior?

Users can set a different directory name or create a workspace in an existing directory.

Does this PR introduce a breaking change?

  • [x] No

mgred avatar Jul 04 '22 10:07 mgred

One thing that looks a bit weird: when running e.g. yarn create @bazel my_test_workspace --typescript --workspaceDir=. The Next steps section would suggest to 1. cd . which is obviously not necessary. We could avoid this by automatically running the install process after worksapce creation. Any ideas on that?

mgred avatar Jul 04 '22 10:07 mgred

Hey, sorry no one looked at your PR!

suggest to 1. cd .

sure, it could do something clever for that case

alexeagle avatar Sep 27 '22 04:09 alexeagle