rules_nodejs icon indicating copy to clipboard operation
rules_nodejs copied to clipboard

{npm,yarn}_install: add note that exports_directories_only is incompatible with RE

Open Yannic opened this issue 3 years ago • 1 comments

If enabled, only the top-level directories will be uploaded as inputs, so the remote action will see an empty directory under node_modules and fail.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature (please, look at the "Scope of the project" section in the README.md file)
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

Other information

Yannic avatar May 27 '22 23:05 Yannic

Hm, this seems like a bug. Our understanding was that copying the folders made it work with RBE and these tests are being run on Google cloud RBE via Bazel CI

alexeagle avatar May 29 '22 15:05 alexeagle

This Pull Request has been automatically marked as stale because it has not had any activity for 6 months. It will be closed if no further activity occurs in 30 days. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

github-actions[bot] avatar Nov 29 '22 02:11 github-actions[bot]

This PR was automatically closed because it went 30 days without any activity since it was labeled "Can Close?"

github-actions[bot] avatar Dec 30 '22 02:12 github-actions[bot]